Build fixes #7
Merged
Build fixes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 27, 2012 13:34
libQtCore often, but not always includes the required functionality from libz. This is needed for example on openSUSE 12.1 and 12.2.
This is needed at least on openSUSE 12.1 and 12.2.
|
Thanks for the fixes, and for checking with ubuntu too. I can see if I get the chance to check with red hat, but I am merging in the mean time. |
lukka
added a commit
to lukka/ResInsight
that referenced
this pull request
Apr 1, 2020
# This is the 1st commit message: use run-vcpkg@v1 and run-cmake@v1 # This is the commit message OPM#2: enable cmake tracing and dump of cmakecache.txt # This is the commit message OPM#3: print python version and environment # This is the commit message OPM#4: pwsh vs cmd environment? # This is the commit message OPM#5: cmd vs pwsh? # This is the commit message OPM#6: cmakecache after build # This is the commit message OPM#7: pwsh vs cmd # This is the commit message OPM#8: pwsh vs cmd # This is the commit message OPM#9: use run-cmake with fix for vxcproj's PATH management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes required for correct linking on openSUSE 12.1, 12.2 and Fedora 17 (that I have tested). I've also checked that it still seems to compile and link fine on Ubuntu 12.04 after the changes.
I've tried to make the additions in the style already used in the CMake files, but I am not terribly proficient with CMake so i may have made some style blunder.