-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HAVE_ECL_INPUT and HAVE_ECL_OUTPUT conditionals #1129
base: master
Are you sure you want to change the base?
Conversation
jenkins build this opm-material=352 opm-grid=401 opm-models=566 opm-simulators=2072 opm-upscaling=283 please |
Please refrain from merging until we have broad community support for the change. |
I agree with @alfbr. I don't think this should be merged before we have a broad discussion about the topic. Including the repository structures as we have it now. As Libecl is gone we may think differently about the topic. If I remember correctly the conditional dependency was to a large degree motivated from the libecl dependency. Currently there are simulators in opm-models that don't depend on opm-common. Maybe we should keep the conditionals dependency on HAVE_ECL_INPUT and instead remove the conditional dependency on opm-common in opm-models? Maybe a hangout on the topic after the release? |
jenkins build this opm-material=352 opm-grid=401 opm-models=566 opm-simulators=2072 opm-upscaling=283 please |
Since I suggested this in #1127 I would obviously like to merge this; not a big thing - but it will reduce complexity somewhat. I acknowledge the wish for a broader discussion before a decision is made; but that leads to an important point: How do actually reach a consensus on questions like this? |
I support @totto82' suggestion to have a hangout about the topic (future module structure and dependencies) with interested participants after the release. |
Time to merge this? |
I am not against merging this, but I would like to keep the opportunity to include opm-grid opm-material and opm-models as modules using the dune build system. I.e. the downstream changes should be HAVE_ECL_INPUT/OUTPUT--> HAVE_OPM_COMMON, IMO. |
OK - we have had 1.5 years with no real objections. Time to revive this. |
That must have been a time when the buildsystem was replicated in every module. I doubt that it is still the case. But even if opm-common is needed it might make sense to deactivate ECL (it takes a lot of time and if you don't need it, you might not want to build it ....). |
opm-common (should) always provide these. closes #1127