Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Existing Cartesian-to-IJK Functionality to Determine NNCs in MULTREGT #3639

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Use Existing Cartesian-to-IJK Functionality to Determine NNCs in MULTREGT #3639

merged 3 commits into from
Aug 22, 2023

Commits on Aug 21, 2023

  1. Switch to Numeric Indices for Record References 

    A numeric index serves the same purpose as a pointer in this very
specific instance and also has the benefit of being easily
transferable between processes.  This, in turn, means we can remove
the 'getSearchMap()' and 'constructSearchMap()' member functions.
    @bska
    bska committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    2dc650f View commit details
    Browse the repository at this point in the history

  2. Tidy Up MULTREGT Scanner Files 

    In particular, ensure that we include all requisite headers, hide
type aliases that are not needed outside the class, consistently use
std::size_t, split a few long lines, and switch to range-for in one
location.
    @bska
    bska committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    2c74d03 View commit details
    Browse the repository at this point in the history

  3. Use Existing Cartesian-to-IJK Functionality 

    This commit replaces the data members 'nx', 'ny', and 'nz' with a
copy of the GridDims object passed as an argument to the
constructor.  In turn, this enables using GridDims::getIJK() to
compute the cell's IJK tuple from its global Cartesian index instead
of implementing the same calculation locally (and incorrectly).

While here, also include the layer index (K) in determining whether
or not a connection is an NNC, and do this just once instead of once
for each MULTREGT record.  Cells (I,J,K) and (I,J,K+3) might be
connected across pinched-out layers and for the purposes of MULTREGT
that connection should be treated as an NNC.
    @bska
    bska committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    f32ff86 View commit details
    Browse the repository at this point in the history