-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/py action build only one shared library #4029
Fix/py action build only one shared library #4029
Conversation
jenkins build this opm-simulators=5306 please |
9f25cb7
to
70e0b9b
Compare
jenkins build this opm-simulators=5306 please |
cd99c27
to
f2c0ab7
Compare
jenkins build this please |
jenkins build this please |
683543e
to
dcd7e87
Compare
jenkins build this please |
dcd7e87
to
e519ef9
Compare
jenkins build this please |
e519ef9
to
987e677
Compare
jenkins build this please |
987e677
to
e38826f
Compare
jenkins build this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one I now also tested with python3.12 and it works.
Concerning the *.pyi files. I really think we should install them somewhere. I am no expert with this but it seems like they usually should lie next to the *.py files.
Would be cool if you would try this option with VSCode (without setting any variable besides PYTHONPATH):
- rename it to init.pyi and put it into
<build-dir>/python/opm_embedded
(and install it)`
python/README.md
Outdated
For embedding python, see the [documentation](https://opm-project.org/?page_id=1454). | ||
|
||
To enable tooltips for opm_embedded on VSCode (embedded python code): Copy the file "<opm-common-folder>/python/opm_embedded.pyi" in the folder at "python.analysis.stubPath" of VS Code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should read:
opm_embedded in VSCode ... to the folder defined in variable ...
e38826f
to
cb2a857
Compare
jenkins build this please |
25a5810
to
185b7fb
Compare
jenkins build this please |
185b7fb
to
8224d69
Compare
8224d69
to
7937503
Compare
…tomatically taken from the globally installed python There are two reasons for this change: - Avoid a duplicate module creation - The code in OPM_EMBEDDED is a copy of PYBIND11_EMBEDDED_MODULE - without the following check: if (Py_IsInitialized() != 0) { //pybind11_fail("Can't add new modules after the interpreter has been initialized"); } This is causing problems for Python 3.12 and is likely to cause further problems in the future
…n the class PythonInterp
7937503
to
2b017ba
Compare
jenkins build this please |
@bska @hakonhagland @akva2 @blattms: If there are no further wishes on this PR, can it be merged to master? I'd like to include this in the 2024.04 release :) Thanks! |
@lisajulia Yes, it looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, merging.
This PR builds on #4017.
This PR removes the creation of an embedded python module.