-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add needed/remove unneeded linker dependencies #62
Conversation
This seems right at least for the case of dynamic libraries, but I'm ever so slightly concerned about the case of a static-only build (i.e., configuring OPM-Core with the |
I would say that this is yet another argument to use dune's DUNE_CHECK_ALL macro to detect the dune dependencies.... Only tangentially related: would it not make sense to change the default for opm-core to --disable shared? This would save people who compile it via dunecontrol (me) some headaches... |
@andlaus: As far as I can tell, there is no way As for |
tested on Debian. Compiles and provides SUPERLU support in dune-istl. Concerning $BLAS: It is not defined anywhere. |
Thanks, I'll merge this right away! |
Add needed/remove unneeded linker dependencies
okay, then I misunderstood the issue at hand. I thought that roland identified superLU as unneeded in 45c21f4 which would not have happened if it was implicitly pulled in by dune.
of course you can, but if you don't specify it (and normally, there is no reason to do so IMO), the defaults of Dune and OPM-core mismatch which leads to quite strange error messages when you try to compile the beast... |
On my Ubuntu 12.04, I am unable to get a clean build if these libraries aren't added/removed. I reckon that there shouldn't be problems on other distributions (CentOS, RHEL, SuSE) but alas I haven't tested.