Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add needed/remove unneeded linker dependencies #62

Merged
merged 3 commits into from
Oct 11, 2012
Merged

Conversation

rolk
Copy link
Member

@rolk rolk commented Oct 10, 2012

On my Ubuntu 12.04, I am unable to get a clean build if these libraries aren't added/removed. I reckon that there shouldn't be problems on other distributions (CentOS, RHEL, SuSE) but alas I haven't tested.

@rolk rolk mentioned this pull request Oct 10, 2012
@bska
Copy link
Member

bska commented Oct 11, 2012

This seems right at least for the case of dynamic libraries, but I'm ever so slightly concerned about the case of a static-only build (i.e., configuring OPM-Core with the --disable-shared option). I'm afraid I don't have easy access to Ubuntu 12.04 at the moment, so would you mind testing if these commits (and especially commit b608871) somehow affects your ability use --disable-shared?

@andlaus
Copy link
Contributor

andlaus commented Oct 11, 2012

I would say that this is yet another argument to use dune's DUNE_CHECK_ALL macro to detect the dune dependencies....

Only tangentially related: would it not make sense to change the default for opm-core to --disable shared? This would save people who compile it via dunecontrol (me) some headaches...

@bska
Copy link
Member

bska commented Oct 11, 2012

@andlaus: As far as I can tell, there is no way DUNE_CHECK_ALL will solve the particular problem being discussed in issue #58. The problem is caused by an incompatibility in two of Ubuntu 12.04's software packages, of which (Dune's slightly adapted) SuperLU macro brings in one and AX_BLAS the other.

As for --disable-shared: Is there a reason you can't pass that through CONFIGURE_FLAGS in your options file?

@blattms
Copy link
Member

blattms commented Oct 11, 2012

tested on Debian. Compiles and provides SUPERLU support in dune-istl.

Concerning $BLAS: It is not defined anywhere.

@bska
Copy link
Member

bska commented Oct 11, 2012

Thanks,

I'll merge this right away!

bska added a commit that referenced this pull request Oct 11, 2012
Add needed/remove unneeded linker dependencies
@bska bska merged commit 09b2ecc into OPM:master Oct 11, 2012
@andlaus
Copy link
Contributor

andlaus commented Oct 11, 2012

As far as I can tell, there is no way DUNE_CHECK_ALL will solve the particular problem being discussed in issue #58. The problem is caused by an incompatibility in two of Ubuntu 12.04's software packages, of which (Dune's slightly adapted) SuperLU macro brings in one and AX_BLAS the other.

okay, then I misunderstood the issue at hand. I thought that roland identified superLU as unneeded in 45c21f4 which would not have happened if it was implicitly pulled in by dune.

As for --disable-shared: Is there a reason you can't pass that through CONFIGURE_FLAGS in your options file?

of course you can, but if you don't specify it (and normally, there is no reason to do so IMO), the defaults of Dune and OPM-core mismatch which leads to quite strange error messages when you try to compile the beast...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants