Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch of collecting data in non-parallel run. #138

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

blattms
Copy link
Member

@blattms blattms commented Jan 18, 2017

Might save some time, space, and suprises.

Completes #137. @andlaus merges faster than I commit.

Might save some time, space, and suprises.
@blattms
Copy link
Member Author

blattms commented Jan 18, 2017

and gets rid of the assertion mentioned in #137

@andlaus
Copy link
Contributor

andlaus commented Jan 18, 2017

push green if you deem it to be ready.

@blattms
Copy link
Member Author

blattms commented Jan 18, 2017

I will not self merge. Otherwise I cannot complain about that in the future anymore.

@atgeirr
Copy link
Member

atgeirr commented Jan 18, 2017

Now that is a deadlock...

@andlaus
Copy link
Contributor

andlaus commented Jan 18, 2017

I will not self merge. Otherwise I cannot complain about that in the future anymore.

ok, I'll merge, but I refuse to be responsible for any breakage.

@andlaus andlaus merged commit 5f5ecf0 into OPM:master Jan 18, 2017
@atgeirr
Copy link
Member

atgeirr commented Jan 18, 2017

ok, I'll merge, but I refuse to be responsible for any breakage.

I think a maintainer will always at least share the responsibility for handling a situation where things break, unless bullied by the PR author to merge :-) (I do not think that is the case here.)

More to the point: did you check this @andlaus, by reading or running the code, or both?

@andlaus
Copy link
Contributor

andlaus commented Jan 18, 2017

Well, I think that the author of a patch has a certain responsibility to test and self-review the stuff before opening a PR. (at least myself has been doing this for my PRs during the last few years as you've doubtlessly noticed. ;))

I looked at the code, and nothing seemed to be obviously wrong, but I usually only compile stuff in optimized mode and I do not run flow_ebos in parallel because the latter does not work yet anyway. (the first point was also true for #137, BTW.)

@blattms blattms deleted the fix-pr137 branch January 18, 2017 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants