-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EclipseIO::writeTimestep ensure summary data. #160
Conversation
jenkins build this with downstreams update_data please |
jenkins run norne spe polymer please update_data please |
Codeblocks in EclipseIO::writeTimestep( ) have been reorder to ensure that summary data is added also for substeps.
5f2508c
to
64567ff
Compare
jenkins build this with downstreams update_data please |
Reason: OPM/opm-output#160 ert = d52d7dccd77ab1412e20a27a5cb2f80d1d992829 opm-common = 7222b210c72bb719fbd9481dea793016a9805646 opm-core = c5a80e97a2b535ad9f90a9f7a133cb3573bd1cdf opm-grid = f55366ef5beeb92808c308bd20ab0750bc849b8a opm-material = 22d1301045642e65cfb711bdbfa8e5e335572ec1 opm-parser = f52929199035baed2db7507fa1e23e15b73dfdce opm-output = e075002b6f293e15785e14e0182fb4c8b3b65f95 ewoms = 3e4d1c5612c371d14874b85aad87240911678b51 opm-simulators = e075002b6f293e15785e14e0182fb4c8b3b65f95
Reason: OPM/opm-output#160 ert = d52d7dccd77ab1412e20a27a5cb2f80d1d992829 opm-common = 7222b210c72bb719fbd9481dea793016a9805646 opm-core = c5a80e97a2b535ad9f90a9f7a133cb3573bd1cdf opm-grid = f55366ef5beeb92808c308bd20ab0750bc849b8a opm-material = 22d1301045642e65cfb711bdbfa8e5e335572ec1 opm-parser = f52929199035baed2db7507fa1e23e15b73dfdce opm-output = 1ba1cc57b441459d30b11ba0ec44c427d3238cc9 ewoms = 3e4d1c5612c371d14874b85aad87240911678b51 opm-simulators = 1ba1cc57b441459d30b11ba0ec44c427d3238cc9
@akva2: The PR: https://github.com/OPM/opm-data/issues/178 looks fine, but the changes in this PR will mandate updates also to to the norne++ reference data - is that within scope of the |
jenkins build this with downstreams opm-data=178 please |
1 similar comment
jenkins build this with downstreams opm-data=178 please |
jenkins build this with downstreams opm-data=177 please |
currently not supported, not necessarily out of scope but i have only considered regression tests for now. |
Ok - I'll go the manual route then. |
Ehhh - is it possible to apply for a opm-data PR with updates to all the reference data[1]? As someone not doing this on a regular basis (and I guess I am actually number two on the list - I must admit I find this quite heavy going), [1]: The summary file |
which test doesn't update the unsmr file ? ref https://github.com/OPM/opm-simulators/blob/master/tests/update_reference_data.sh#L23 |
All tests update it - but for this particular PR it might be unchanged for a couple of the tests. |
then i simply do not understand what you are asking for. |
Just assistance with the manual grunt work / book-keeping required to run all the integration tests and update the reference data, without f...ing up somewhere. |
status for the integration tests:
|
OK - thank you for the update. I'll merge - and take the flak if there is one. |
jenkins build this with downstreams update_data please |
Reason: OPM/opm-output#160 ert = d52d7dccd77ab1412e20a27a5cb2f80d1d992829 opm-common = 7222b210c72bb719fbd9481dea793016a9805646 opm-core = c5a80e97a2b535ad9f90a9f7a133cb3573bd1cdf opm-grid = f55366ef5beeb92808c308bd20ab0750bc849b8a opm-material = 22d1301045642e65cfb711bdbfa8e5e335572ec1 opm-parser = f52929199035baed2db7507fa1e23e15b73dfdce opm-output = 1ba1cc57b441459d30b11ba0ec44c427d3238cc9 ewoms = 3e4d1c5612c371d14874b85aad87240911678b51 opm-simulators = 1ba1cc57b441459d30b11ba0ec44c427d3238cc9
jenkins build this with downstreams opm-data=179 please |
There was an incorrect early return in the writeTimestep( ) routine. The consequence of that was that summary data was not written for sub-report time resolution. This will require reference data updates:
WOPT = \int_{t_1}^{t_2} dt WOPR
which will be integrated over a complete report step, instead of subdividing the integeral over the timesteps of the simulator.