Completion production/injection rates/totals; Field keywords #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small set of the completion family of keywords, water/oil/gas production and injection. The tests and example data file are updated accordingly, with edge cases.
In line with Eclipse water cuts, gas-oil ratio etc. only applies to production values, rather than all rates. This sparked some other refactoring that moves the negative-else-zero logic into the rate calculation.
Support for rate or rate-derived keywords (i.e. sans pressure, sales etc.) from the Field family of keywords.
jokva
changed the title
A few short lines to make the summary test deck more understandable.
| * ecl_wells are wells from the deck, provided by opm-parser. wells is | ||
| * simulation data | ||
| * ecl_wells are wells from the deck, provided by opm-parser. active_index is | ||
| * the index of the block in question. wells is simulation data. | ||
| */ | ||
| struct fn_args { | ||
| const std::vector< const Well* >& ecl_wells; |
There was a problem hiding this comment.
As in this well - maybe schedule_wells would be a better name?
There was a problem hiding this comment.
Good one, I'll update in the morning.
|
I will force merge this: OPM/opm-simulators#763 tomorrow and restart Travis. |
|
Excellent. Works on my machine, but you never know. I'll address the issues tomorrow. |
There are no such thing as sum-over-completions or over multiple wells. Treat them as such to communicate this, rather than sum-over-list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small set of the completion family of keywords, water/oil/gas
production and injection. The tests and example data file are updated
accordingly, with edge cases.
Requires Ensembles/ert#1167 and OPM/opm-parser#881 (bugfixes).
note: I've added support for a set of Field keywords to this PR. Easily split up obviously, but they're along the same lines so I figured it's fine.