Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw now contains name() of deckKeyword #801

Merged
merged 1 commit into from
May 10, 2016
Merged

Throw now contains name() of deckKeyword #801

merged 1 commit into from
May 10, 2016

Conversation

pgdr
Copy link
Contributor

@pgdr pgdr commented May 10, 2016

Replaces error message "Not a data keyword ?" with "Not a data keyword "KEYWORD"?"

@joakim-hove joakim-hove merged commit c373fd4 into OPM:master May 10, 2016
@andlaus
Copy link
Contributor

andlaus commented May 10, 2016

IMO that's a good start. Question: Is canonical location tracking planned?

(e.g. for keywords like "WCONHIST", just knowing the name is probably not too useful.)

@jokva
Copy link
Contributor

jokva commented May 10, 2016

It's not planned in the sense that we have a list of throws or error messages to update, but if we do stumble across them with more information floating about we'll certainly add when it's convenient.

@andlaus
Copy link
Contributor

andlaus commented May 10, 2016

but if we do stumble across them with more information floating about we'll certainly add when it's convenient.

To have any decent chance of this 'being convenient', I suppose the first step needs to be to add getFileName() and getLineNumber() methods to Deck(Keyword|Record|Item). For the keyword and probably also for the record class I don't see a problem because there are typically not too many of those objects, but doing it naively may be an issue for the DeckItem class.

That said, I personally need to create decks only sporadically, so I currently assign a very low priority for this feature.

@pgdr pgdr mentioned this pull request May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants