Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always allocate buffers for storing flows if BFLOW[I|J|K] is requested #4904

Merged
merged 1 commit into from Oct 3, 2023

Conversation

vkip
Copy link
Member

@vkip vkip commented Oct 2, 2023

Currently these buffers are not allocated unless restart output is requested, causing segfault initially if BFLOW[I|J|K] is requested without RPTRST in the SOLUTION section.

…ed initially even if there is no RPTRST in the solution section.
@vkip
Copy link
Member Author

vkip commented Oct 2, 2023

jenkins build this please

@vkip vkip changed the title Always allocated buffers for storing flows if BFLOW[I|J|K] is requested Always allocate buffers for storing flows if BFLOW[I|J|K] is requested Oct 2, 2023
Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need that precaution for now. I do believe we should revise the implementation here at some point because it's rather expensive as of right now, but at least we should not generate out-of-bounds subscripts until we do. I'll merge into master.

@bska bska merged commit d1b9084 into OPM:master Oct 3, 2023
1 check passed
@vkip vkip deleted the bflowijk_alloc_fix branch October 3, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants