-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[testing] tightening tolerance wells to be 1.e-8 #5280
base: master
Are you sure you want to change the base?
Conversation
jenkins build this please |
benchmark please |
Did not manage to check all the regression tests. For the many of the ones I checked, it does not look causing any running failures. And also, for many, it avoids some time step cuts. Maybe it is time to tighten the well tolerance. But it should really depends on the tests for the field cases. |
There are cases related to network also call for tighter tolerance of 1.e-8, and 1.e-6 (1.e-4 by default) was not sufficient. |
Benchmark result overview:
View result details @ https://www.ytelses.com/opm/?page=result&id=2435 |
benchmark please |
Benchmark result overview:
View result details @ https://www.ytelses.com/opm/?page=result&id=2480 |
If the benchmark is reliable, it looks that we do not need to worry about the performance impact. |
benchmark please |
Benchmark result overview:
View result details @ https://www.ytelses.com/opm/?page=result&id=2481 |
jenkins build this please |
No description provided.