Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] tightening tolerance wells to be 1.e-8 #5280

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GitPaean
Copy link
Member

No description provided.

@GitPaean
Copy link
Member Author

jenkins build this please

@GitPaean
Copy link
Member Author

benchmark please

@GitPaean
Copy link
Member Author

Did not manage to check all the regression tests. For the many of the ones I checked, it does not look causing any running failures. And also, for many, it avoids some time step cuts.

Maybe it is time to tighten the well tolerance. But it should really depends on the tests for the field cases.

@GitPaean
Copy link
Member Author

There are cases related to network also call for tighter tolerance of 1.e-8, and 1.e-6 (1.e-4 by default) was not sufficient.

@ytelses
Copy link

ytelses commented Apr 13, 2024

Benchmark result overview:

Test Configuration Relative
opm-git OPM Benchmark: drogon - Threads: 1 - FOPT (Total Oil Production At End Of Run) 1
opm-git OPM Benchmark: drogon - Threads: 8 - FOPT (Total Oil Production At End Of Run) 0.999
opm-git OPM Benchmark: punqs3 - Threads: 1 - FOPT (Total Oil Production At End Of Run) 1
opm-git OPM Benchmark: punqs3 - Threads: 8 - FOPT (Total Oil Production At End Of Run) 1
opm-git OPM Benchmark: smeaheia - Threads: 1 - FOPT (Total Oil Production At End Of Run) 1
opm-git OPM Benchmark: smeaheia - Threads: 8 - FOPT (Total Oil Production At End Of Run) 1
opm-git OPM Benchmark: spe10_model_1 - Threads: 1 - FOPT (Total Oil Production At End Of Run) 1
opm-git OPM Benchmark: spe10_model_1 - Threads: 8 - FOPT (Total Oil Production At End Of Run) 1
opm-git OPM Benchmark: flow_mpi_extra - Threads: 1 - FOIT (Total Oil Injection At End Of Run) 1.01
opm-git OPM Benchmark: flow_mpi_extra - Threads: 8 - FOIT (Total Oil Injection At End Of Run) 0.998
opm-git OPM Benchmark: flow_mpi_norne - Threads: 1 - FOPT (Total Oil Production At End Of Run) 1
opm-git OPM Benchmark: flow_mpi_norne - Threads: 8 - FOPT (Total Oil Production At End Of Run) 1
opm-git OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 1 - FOPT (Total Oil Production At End Of Run) 1
opm-git OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 8 - FOPT (Total Oil Production At End Of Run) 0.978
  • Speed-up = Total time master / Total time pull request. Above 1.0 is an improvement. *

View result details @ https://www.ytelses.com/opm/?page=result&id=2435

@GitPaean
Copy link
Member Author

benchmark please

@ytelses
Copy link

ytelses commented May 23, 2024

Benchmark result overview:

Test Configuration Relative
opm-git OPM Benchmark: drogon - Threads: 1 0.995
opm-git OPM Benchmark: drogon - Threads: 8 1.014
opm-git OPM Benchmark: punqs3 - Threads: 1 1.024
opm-git OPM Benchmark: punqs3 - Threads: 8 0.997
opm-git OPM Benchmark: smeaheia - Threads: 1 1.022
opm-git OPM Benchmark: smeaheia - Threads: 8 1.008
opm-git OPM Benchmark: spe10_model_1 - Threads: 1 1.003
opm-git OPM Benchmark: spe10_model_1 - Threads: 8 1
opm-git OPM Benchmark: flow_mpi_extra - Threads: 1 1.023
opm-git OPM Benchmark: flow_mpi_extra - Threads: 8 0.998
opm-git OPM Benchmark: flow_mpi_norne - Threads: 1 1.002
opm-git OPM Benchmark: flow_mpi_norne - Threads: 8 0.981
opm-git OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 1 1.001
opm-git OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 8 0.985
  • Speed-up = Total time master / Total time pull request. Above 1.0 is an improvement. *

View result details @ https://www.ytelses.com/opm/?page=result&id=2480

@GitPaean
Copy link
Member Author

If the benchmark is reliable, it looks that we do not need to worry about the performance impact.

@GitPaean
Copy link
Member Author

benchmark please

@ytelses
Copy link

ytelses commented May 24, 2024

Benchmark result overview:

Test Configuration Relative
opm-git OPM Benchmark: drogon - Threads: 1 0.997
opm-git OPM Benchmark: drogon - Threads: 8 1.025
opm-git OPM Benchmark: punqs3 - Threads: 1 1.002
opm-git OPM Benchmark: punqs3 - Threads: 8 0.997
opm-git OPM Benchmark: smeaheia - Threads: 1 1.02
opm-git OPM Benchmark: smeaheia - Threads: 8 1.006
opm-git OPM Benchmark: spe10_model_1 - Threads: 1 0.97
opm-git OPM Benchmark: spe10_model_1 - Threads: 8 0.998
opm-git OPM Benchmark: flow_mpi_extra - Threads: 1 1.023
opm-git OPM Benchmark: flow_mpi_extra - Threads: 8 1.004
opm-git OPM Benchmark: flow_mpi_norne - Threads: 1 0.998
opm-git OPM Benchmark: flow_mpi_norne - Threads: 8 0.99
opm-git OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 1 1.002
opm-git OPM Benchmark: flow_mpi_norne_4c_msw - Threads: 8 0.999
  • Speed-up = Total time master / Total time pull request. Above 1.0 is an improvement. *

View result details @ https://www.ytelses.com/opm/?page=result&id=2481

@GitPaean GitPaean mentioned this pull request May 24, 2024
@GitPaean
Copy link
Member Author

jenkins build this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants