Accumulate CNV Pore-Volume Sum for Interior Cells Only #5307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
bska
force-pushed
the
cnv-error-accum-interior
branch
from
261ee0f
to
7e8d901
Compare
bska
force-pushed
the
cnv-error-accum-interior
branch
2 times, most recently
from
7d66280
to
3db70d8
Compare
|
jenkins build this please |
bska
force-pushed
the
cnv-error-accum-interior
branch
from
3db70d8
to
6b696d2
Compare
|
jenkins build this please |
bska
force-pushed
the
cnv-error-accum-interior
branch
6 times, most recently
from
8f02ceb
to
77d065e
Compare
The 'interiorBorder' category is *probably* equivalent to the 'interior' category for codimension zero elements, but it's better to be safe than sorry. We don't want to accumulate pore-volume contributions twice.
bska
force-pushed
the
cnv-error-accum-interior
branch
from
77d065e
to
1e9943b
Compare
|
jenkins build this please |
Build check is green. Merging per prior approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
interiorBordercategory is probably equivalent to theinteriorcategory for codimension zero elements, but it's better to be safe than sorry. We don't want to accumulate pore-volume contributions twice.