Fixed missing unit conversion for total fluid in place #987
Conversation
|
@atgeirr can you take a look at this and see if it solves the reported issue on your end? |
| fip[i][6] = unit::convert::to(fip[i][6], unit::barsa); | ||
| } | ||
| else if (units.getType() == UnitSystem::UnitType::UNIT_TYPE_METRIC) { | ||
| fip[6] = unit::convert::to(fip[6], unit::barsa); | ||
| } |
There was a problem hiding this comment.
To guard agains future trouble, we should add a final else branch which throws (in case someone tries to run with LAB units).
There was a problem hiding this comment.
I agree. Just pushed an update with that
|
It solves the reported issue, thank you for the fix! Will merge when green. |
|
Do we need the same fix for flow_ebos? |
Unfortunately, yes, since it duplicates rather than reuse the simulator class. |
IIRC, the reason why flow_ebos does this is that the current FIP-code sometimes uses ADBs and other stuff that depends on Eigen which is not available in |
Refactor relperm diagnostics using OpmLog functionalities.
This (hopefully) fixes the issue with SPE1CASE2, in which the field total fluid in place is reported in the wrong units.