Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

last_vacuum should not return critical if there was no write since last vacuum #129

Closed
maethor opened this issue Nov 6, 2017 · 4 comments · Fixed by #272
Closed

last_vacuum should not return critical if there was no write since last vacuum #129

maethor opened this issue Nov 6, 2017 · 4 comments · Fixed by #272
Assignees
Milestone

Comments

@maethor
Copy link

maethor commented Nov 6, 2017

Hi,

When there is no write on a database since the last vacuum, vacuum does not run. Even a manual vacuum full analyse does not run the vacuum. So on a database where there is no write, the last_vacuum probe will always return CRITICAL. Would it be possible to detect this case?

http://grokbase.com/t/postgresql/pgsql-bugs/10asqyzkn2/bug-5722-vacuum-full-does-not-update-last-vacuum-statistics/oldest

Alternatively, it should be possible to run last_vacuum and last_analyse without thresholds, for graphing purposes only.

Thanks.

@frost242
Copy link
Member

Hi,

We'll address this issue in a later release. Version 2.3 will be released next week and I hope to do another release with this fix soon.

Thanks

@frost242 frost242 self-assigned this Nov 10, 2017
@frost242 frost242 added this to the release 2.4 milestone Mar 16, 2018
@frost242
Copy link
Member

I've started working on this issue, a first commit is here but the approach is too naive: https://github.com/frost242/check_pgactivity/tree/last_vacuum
I'll sort this out soon.

@ioguix ioguix modified the milestones: release 2.4, release 2.5 Feb 21, 2019
@Krysztophe
Copy link
Collaborator

For graphing purpose, it is possible to set the thresholds in the far future (eg -w '99999d' -c '99999d') should be enough.

I suppose it is best to let thresholds as mandatory, so they can't be forgotten.

ioguix added a commit to ioguix/check_pgactivity that referenced this issue Oct 30, 2020
@ioguix
Copy link
Member

ioguix commented Nov 2, 2020

Hi,

PR #272 is waiting for opinions on perfdata. It will be merged for release 2.5 and this issue will be closed if no further discussions happen in the meantime.

ioguix added a commit that referenced this issue Nov 3, 2020
Do not alert lack of maintenance on inactive db

closes #129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants