Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 13 update #4533

Closed
nbintertech opened this issue Jun 4, 2021 · 4 comments
Closed

Angular 13 update #4533

nbintertech opened this issue Jun 4, 2021 · 4 comments
Assignees
Labels
Application General Tool wide issue

Comments

@nbintertech
Copy link
Collaborator

nbintertech commented Jun 4, 2021

update to Angular 13

@nbintertech nbintertech added the Application General Tool wide issue label Jun 4, 2021
@nbintertech nbintertech self-assigned this Jun 18, 2021
@rmroot
Copy link
Collaborator

rmroot commented Jun 30, 2021

While you are at it can you make sure to check out all vulnerabilities that show up on npm install please

@nbintertech
Copy link
Collaborator Author

Branch is updated to ng 12 and compiling/running successfully. There are 2 loose ends:

  1. Initial build time is ridiculously slow (15-20 mins)
  1. There is a deprecated :lang selector somewhere in our 3rd party styles
  • Also need some researching to find where this is. Possibly upgrade to bootstrap 5 or if there is a minor 4 release that removes :lang
    ng12.png.

@nbintertech nbintertech changed the title Angular 12 update Angular 13 update Nov 19, 2021
@nbintertech
Copy link
Collaborator Author

Try this again once we get MEASUR / WASM integrated

@nbintertech
Copy link
Collaborator Author

Updated to Angular 13 and can't build due to webpack errors. Branch at issue-4533-b

Problem:

  • Plotly depends on node modules 'fs' and 'path', instead of native browser apis
  • Angular 11 used webpack 4 which provided polyfill support for these. Angular 13 uses webpack 5 which no longer has the polyfills

Targetting plotly 1.58 or Plotly 2.6.2 -2.9 (problem occurs on 'stream' in this v), I tried:

  • adding paths to tsconfig as recommended. works for 'path' but not fs "paths": {
    "fs": [ "./node_modules/browserify-fs" ],
    "path": [ "./node_modules/path" ]
    },
  • adding path for browserify-fs

At this point, looking at VERIFI, maybe the MEASUR tsconfig needs a revamp. If all else fails there is a package to modify a custom webpack config with a few lines. Not ideal

Fall back solution --> the upgrade to Angular 12 built fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Application General Tool wide issue
Projects
None yet
Development

No branches or pull requests

3 participants