Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU cycling fixes #165

Merged
merged 2 commits into from
May 16, 2024
Merged

CPU cycling fixes #165

merged 2 commits into from
May 16, 2024

Conversation

tskluzac
Copy link
Collaborator

In this branch I changed how we accessed internal queues to 'ease up' on the CPU.

Please test using the following:

  • zambeze start
  • check CPU usage (confirm under 2%)
  • launch imagemagick_files.py
  • after running, check CPU usage (confirm under 2%)

@tskluzac tskluzac requested a review from wigging May 15, 2024 14:40
@wigging
Copy link
Collaborator

wigging commented May 15, 2024

Don't forget to connect this to the corresponding issue.

@wigging wigging force-pushed the skluzacek-fix-cpu-cycling branch from 329133a to 4e68f61 Compare May 15, 2024 15:53
@wigging
Copy link
Collaborator

wigging commented May 15, 2024

I rebased this with the main branch so it can be merged. You will need to delete your local branch then pull down this remote branch if you want it on your computer. Otherwise, you may have some issues trying to pull it down into your existing local branch.

Anyway, I pulled down this branch and ran the imagemagick_files.py example. The example ran fine and my CPU usage remained below 1%. Good job!

@tskluzac
Copy link
Collaborator Author

tskluzac commented May 15, 2024

Closes #161

@tskluzac tskluzac linked an issue May 15, 2024 that may be closed by this pull request
@tskluzac
Copy link
Collaborator Author

@wigging sounds good! I linked the issue and made sure it's passing the ruff checks. Confirmed tests and imagemagick still run on rebased version.

@wigging
Copy link
Collaborator

wigging commented May 15, 2024

I think you committed a bunch of files that should be ignored.

@wigging wigging force-pushed the skluzacek-fix-cpu-cycling branch from fe165da to c3907e0 Compare May 15, 2024 17:37
@wigging wigging force-pushed the skluzacek-fix-cpu-cycling branch from c3907e0 to 47c9b40 Compare May 15, 2024 17:40
@wigging
Copy link
Collaborator

wigging commented May 15, 2024

I reverted the last commit which added a bunch of unrelated files and force pushed the change. I think we're good to go now.

@wigging wigging merged commit b020ae0 into main May 16, 2024
1 check passed
@wigging wigging deleted the skluzacek-fix-cpu-cycling branch May 16, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPU usage near 100%
2 participants