-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more ways to control docker images other than environment variables #58
Comments
How about offering the option to add docker configuration secrets stored in files as the docker docs suggest: That way, both options (environment variables and secret files) can be available to choose from. Or perhaps the container can use secrets files alone in order to standardize security best-practices. I wouldn't mind taking a shot at implementing it if this approach seems acceptable :) |
Hey Mike, thanks for the response 😃 |
…d#58) * Add support to pass sensitive config fields through docker secrets in addition to env variables (for security reasons). * Configurable docker secrets fields: (s3-registry) access-key-id and secret-access-key. * Add SECRETS_FILE_PATH env variable to customize secrets location inside the container.
…d#58) * Add support to pass sensitive config fields through docker secrets in addition to env variables (for security reasons). * Configurable docker secrets fields: (s3-registry) access-key-id and secret-access-key, (redis-azure-blobs) container-sas and redis-config, (azure-blobs) container-sas. * Add SECRETS_FILE_PATH, AZURE_SECRET_FILE_PATH and REDIS_SECRETS_FILE_PATH env variables to customize secrets location inside containers.
…d#58) * Add support to pass sensitive config fields through docker secrets in addition to env variables (for security reasons). * Configurable docker secrets fields: (s3-registry) access-key-id and secret-access-key, (redis-azure-blobs) container-sas and redis-config, (azure-blobs) container-sas. * Add SECRETS_FILE_PATH, AZURE_SECRET_FILE_PATH and REDIS_SECRETS_FILE_PATH env variables to customize secrets location inside containers.
…d#58) * Add support to pass sensitive config fields through docker secrets in addition to env variables (for security reasons). * Configurable docker secrets fields: (s3-registry) access-key-id and secret-access-key, (redis-azure-blobs) container-sas and redis-config, (azure-blobs) container-sas. * Add SECRETS_FILE_PATH, AZURE_SECRET_FILE_PATH and REDIS_SECRETS_FILE_PATH env variables to customize secrets location inside containers.
* Add support to pass sensitive config fields through docker secrets in addition to env variables (for security reasons). * Configurable docker secrets fields: (s3-registry) access-key-id and secret-access-key, (redis-azure-blobs) container-sas and redis-config, (azure-blobs) container-sas. * Add SECRETS_FILE_PATH, AZURE_SECRET_FILE_PATH and REDIS_SECRETS_FILE_PATH env variables to customize secrets location inside containers.
currently you control docker deployments with setting environment variables which is an easy solution but considered not secure. These environment variables contain connection strings and maybe other sensitive information. We should allow configuration via files and any other way that makes sense for running dynamico in a container.
The text was updated successfully, but these errors were encountered: