Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report result was found or not #46

Merged
merged 8 commits into from
Jul 13, 2022
Merged

Report result was found or not #46

merged 8 commits into from
Jul 13, 2022

Conversation

adisoluto
Copy link
Contributor

Which issues does it affect?

What it does

  • Allows to define under which conditions a result is considered 'found' or 'not found' and report a metric for each case.

korengal
korengal approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@korengal korengal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work.

@korengal korengal added the large label Jul 12, 2022
@korengal korengal merged commit 5cd4919 into OS-Guild:main Jul 13, 2022
korengal added a commit that referenced this pull request Jul 18, 2022
@korengal
Revert "Report result was found or not (#46)"
52cddda 
This reverts commit 5cd4919.
gioragutt pushed a commit that referenced this pull request Jul 18, 2022
@korengal
Revert "Report result was found or not (#46)" (#49)
f825cd7 
This reverts commit 5cd4919.
@gioragutt gioragutt mentioned this pull request Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korengal korengal korengal approved these changes

Assignees
No one assigned
Labels
large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adisoluto @korengal