Roadmap features: Mqtt broker/subscriber support #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusthjerrild
requested changes
May 16, 2023
| return newDevice; | ||
| } | ||
|
|
||
| private base64Decode(input: string) { |
There was a problem hiding this comment.
This sounds like something that could be used by other components in the future. We could consider making it public?
...devices/iot-device-detail/iot-device-detail-generic/iot-device-detail-generic.component.html
Outdated
Show resolved
Hide resolved
...devices/iot-device-detail/iot-device-detail-generic/iot-device-detail-generic.component.html
Outdated
Show resolved
Hide resolved
...t-device-detail/iot-device-details-mqtt-broker/iot-device-details-mqtt-broker.component.html
Outdated
Show resolved
Hide resolved
… it's checked in can only be unchecked by chosen another iotDevice.
augusthjerrild
approved these changes
May 22, 2023
| @@ -110,7 +109,7 @@ export class BulkMapping { | |||
| receivedMessagesMetadata: undefined, | |||
| metadata: undefined, | |||
| apiKey: undefined, | |||
| id: data.id ? data.id : undefined, | |||
There was a problem hiding this comment.
Is there a reason that we don't want the id to be set in base scenario?
augusthjerrild
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes a csv export of all devices in an application