Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with disabled days #7

Closed
postb99 opened this issue May 22, 2017 · 6 comments
Closed

Error with disabled days #7

postb99 opened this issue May 22, 2017 · 6 comments
Assignees
Labels
Milestone

Comments

@postb99
Copy link
Collaborator

postb99 commented May 22, 2017

From @fgagneten 2 days ago on original's project as comment in this thread: rajeshwarpatlolla#297

There is such a big error. Please, see this video to know what's going on with this fork:
https://streamable.com/0xic0

Using the original library this error not happening. Please, is too important to solve the problem when you limit the first and the last day in the calendar

@postb99 postb99 added the bug label May 22, 2017
@postb99 postb99 added this to the 1.6.0 milestone May 22, 2017
@postb99 postb99 self-assigned this May 22, 2017
@postb99
Copy link
Collaborator Author

postb99 commented May 22, 2017

Please @fgagneten can you give me the configuration you used for the disabled dates.

I start working on it but have few time until Saturday.

As for your other question, about using bower, we usually install projects as bower packages. This is the npm/bower world, but you can live without it, however it's interesting to learn and once you master it you don't have problems with it. Ionic sample app uses it too, if I am right.

@postb99
Copy link
Collaborator Author

postb99 commented May 22, 2017

I see two bugs, after setting a "from/to" period that doesn't start at day 1 of a month and doesn't end at last day of month:

  • the days before the start date's month and after the end date's month are available in the month selector.
  • the start and end days must be taken into account when changing month and keeping the same day.

I need to update my comparison test project too, so that the day is kept when changing month, with original's project master which is ahead the last released version, since I installed the packaged version.

postb99 pushed a commit that referenced this issue May 22, 2017
…to test all possible values for from/to parameters.
@fgagneten
Copy link

fgagneten commented May 22, 2017 via email

@Xarkam
Copy link

Xarkam commented May 22, 2017

@fgagneten I decide to freeze any development until next week.

Please, standby

postb99 pushed a commit that referenced this issue May 29, 2017
…l project's master code to compare behaviors.
postb99 pushed a commit that referenced this issue May 29, 2017
…d blocking for month, need to fix it for days.
@postb99
Copy link
Collaborator Author

postb99 commented Jun 1, 2017

Hi @fgagneten , glad to announce you that half of the bug is fixed, please download this release and enjoy:
https://github.com/OSAMES/ionic-datepicker/releases/tag/fixed_next_previous_month

With any configuration, the day is correctly limited when navigation next/previous month.

Now I work on fixing the available month selection in the month list. This is buggy on original project too.

postb99 pushed a commit that referenced this issue Jun 1, 2017
@fgagneten
Copy link

Glad to know that one part of the bug is fixed. Thanks a lot, specially @postb99 on helping us really fast!

postb99 pushed a commit that referenced this issue Jun 1, 2017
…se the months labels (the other option) but limit to the available months)
postb99 pushed a commit that referenced this issue Jun 2, 2017
…d month names. Work in progress (month selection is empty).
postb99 pushed a commit that referenced this issue Jun 2, 2017
postb99 pushed a commit that referenced this issue Jun 6, 2017
… fix selection and adapt code elsewhere (for example currentMonth. A month is an object now, not just a string).
postb99 pushed a commit that referenced this issue Jun 7, 2017
… : fix code when dropdown selection changes :-)
postb99 pushed a commit that referenced this issue Jun 8, 2017
postb99 pushed a commit that referenced this issue Jun 13, 2017
…ed date correctly change on month selection. Last thing to implement: adjust the selected day of target month to the available days of target month.
postb99 pushed a commit that referenced this issue Jun 14, 2017
…available days of target month OK. Last thing to fix: the available months should change when the year changes (added a test case for this).
postb99 pushed a commit that referenced this issue Jun 15, 2017
…ths by year. Need to add a refresh of month selection list.
postb99 pushed a commit that referenced this issue Jun 16, 2017
… the check when year changes (going to an unavailable month in the other year did nothing instead of going to closest acceptable date).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants