Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot delete files when allowlists are enabled #1337

Closed
johrstrom opened this issue Aug 13, 2021 · 1 comment · Fixed by #1338
Closed

Cannot delete files when allowlists are enabled #1337

johrstrom opened this issue Aug 13, 2021 · 1 comment · Fixed by #1338
Labels
bug Existing functionality not working as expected component/file_browser
Milestone
OOD2.0 Patch Release

Comments

@johrstrom
Copy link
Contributor

Cannot delete files when allowlists are enabled

This stack trace is produced when allowlists are set (OOD_ALLOWLIST_PATH) and you try to delete 1 or more files.

app/models/allowlist_policy.rb:45:in `initialize'
app/models/allowlist_policy.rb:45:in `new'
app/models/allowlist_policy.rb:45:in `real_expanded_path'
app/models/allowlist_policy.rb:30:in `block in permitted?'
app/models/allowlist_policy.rb:30:in `any?'
app/models/allowlist_policy.rb:30:in `permitted?'
app/models/transfer.rb:18:in `block (2 levels) in <class:Transfer>'
app/models/transfer.rb:16:in `each'
app/models/transfer.rb:16:in `block in <class:Transfer>'
app/controllers/transfers_controller.rb:21:in `create'
@johrstrom johrstrom added bug Existing functionality not working as expected component/file_browser labels Aug 13, 2021
@johrstrom johrstrom added this to the OOD2.0 Patch Release milestone Aug 13, 2021
johrstrom added a commit that referenced this issue Aug 13, 2021
@johrstrom
transfer validation checks need to check for nil keys for the rm comm…
d0dbc13 
…and to fix #1337
This was referenced Aug 13, 2021
Merged
Closed
@johrstrom
Copy link
Contributor Author

Lots of great troubleshooing in #1336 so please refer to that ticket as well.

@johrstrom johrstrom mentioned this issue Aug 13, 2021
Open
johrstrom added a commit that referenced this issue Aug 24, 2021
@johrstrom
Bugfix/allowlist rm files (#1338)
1818fb2 
* add tests for failing rm commands

* transfer validation checks need to check for nil keys for the rm command to fix #1337
@johrstrom johrstrom mentioned this issue Nov 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Existing functionality not working as expected component/file_browser
Projects
None yet
Milestone
OOD2.0 Patch Release
Development

Successfully merging a pull request may close this issue.

Bugfix/allowlist rm files OSC/ondemand
1 participant
@johrstrom