Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC Relative Path Support for httpd #3562

Closed
jarulsamy opened this issue May 19, 2024 · 4 comments
Closed

OIDC Relative Path Support for httpd #3562

jarulsamy opened this issue May 19, 2024 · 4 comments
Milestone

Comments

@jarulsamy
Copy link

By default, configuring OIDC in ood_portal.yml generates an absolute path for the OIDC redirect URI in the resulting httpd configuration file.
For example:

# /etc/ood/config/ood_portal.yml
. . .
oidc_uri: "/oidc"
. . .
# /etc/httpd/conf.d/ood-portal.conf
. . .
OIDCRedirectURI https://<fqdn>/oidc
. . .

This works fine in most circumstances, however if one or more server aliases are also specified, then OIDC doesn't work correctly for the alias URLs, since only one URL is populated for the OIDCRedirectURI field in the httpd config.

Removing the fqdn (OIDCRedirectURI /oidc) fixes this. mod_auth_openidc has supported relative paths since 2017 (relevant PR here: OpenIDC/mod_auth_openidc#259).

Could we add a configuration option to generate relative paths for the OIDCRedirectURI option in ood-portal.yml? This would grant better support for multiple server aliases.

@osc-bot osc-bot added this to the Backlog milestone May 19, 2024
@abujeda
Copy link
Contributor

abujeda commented May 20, 2024

I believe this issue has already been resolved:
#3448

https://github.com/OSC/ondemand/blob/master/ood-portal-generator/templates/ood-portal.conf.erb#L134

But, as far as I know, the changes are not yet available in a release.

@johrstrom
Copy link
Contributor

Yes that's correct. It's been fixed and is being backported to 3.1 in #3548 .

@jarulsamy
Copy link
Author

Oh, sweet! Sorry for the duplicate, shame on me for not looking hard enough for a similar issue.

Thanks! I look forward to the backport.

@johrstrom
Copy link
Contributor

Oh, sweet! Sorry for the duplicate, shame on me for not looking hard enough for a similar issue.

No problem at all! It was a very recent addition, so if you'd been a month or so earlier, you'd have gotten there.

Thanks for opening the ticket! It never hurts to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants