Update 3.1 #3548
Merged
Update 3.1 #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support fields that start with numbers in dynamic bc.
redirect to http requests to HTTP_HOST to support aliases.
Add support for configurable redirect host, defaulting to %{HTTP_HOST}.
Use the ps command to count sessions instead of lsof. This was because lsof may cause issues in some environments with permissions (like containers) and indeed may be quite slow. So this changes that for simplicity and speed. --------- Co-authored-by: treydock <tdockendorf@osc.edu>
HazelGrant
previously approved these changes
May 21, 2024
|
Thanks for looking at this. Inspecting it a second time, I think we need the OIDC relative redirect. Looking into it now. |
Use relative OIDCRedirectURI where applicable to support multiple servernames.
|
🤦♂️ we did need #3448 |
HazelGrant
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some things we want to backport and release into 3.1
Other things I'll be patching are just to get tests to run and pass like: