Allowing system configs to set before ood initializers. #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Aug 6, 2021
|
We should review our own initializers and see if there are any that we definitely can't have folks override for security reasons or otherwise. I guess this listed in #1227 is a security concern right - here's a way to make sessions either more or less secure. I guess one side affect of this (maybe not even side - actual affect) is that folks can make ondemand less secure if they override something we have. So I guess we'll just have to think hard about this strategy or if we indeed just want to fix the 1 issue with session stores. |
johrstrom
reviewed
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1227