Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPM packaging tests and RPM packaging rake task #1329

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Conversation

treydock
Copy link
Contributor

Example execution:

rake package:rpm[el7] VERSION=2.0.15

The Github action just takes latest tag in git repo and uses that since the package isn't getting used, just need some version to use for building tar and passing to build script to match tar file.

Fixes #1265

@johrstrom
Copy link
Contributor

I think we're good with this, I just need some clarity on why it's not pulling Source0 from GH and instead using the local tar.gz file. I even tried on 2.0.3.

Why is it using the local tar.gz instead of the remote one?

@treydock
Copy link
Contributor Author

So the way RPMs build, even if you put Source0: https://foo.bar/1.0.0.tar.gz, the tar.gz isn't pulled from foo.bar, that part is just for reference. The 1.0.0.tar.gz must exist in SOURCE directory within build root, so either we download the tar.gz from Github or we generate it from local code, you can't have RPM build process download tar.gz files from remote sources during the build. There are tools outside the RPM build process that can parse the SourceN:... lines and bootstrap them into SOURCE directory for RPM build root and then RPM build would be run, and that's exactly what we do when we build tagged releases. For these testing purposes, we want to build RPM against local code so we build local tar.gz.

For tagged builds, this is where we take Source0: and download tar.gz: https://github.com/OSC/ondemand-packaging/blob/85fb7fce3b19c5c57431e5e6e7ccb890f632cff9/build/Rakefile#L179-L182

@johrstrom johrstrom self-requested a review August 12, 2021 14:03
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this is a good start. I'll create follow up tickets about verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add packaging to Github Actions for testing
3 participants