Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selinux updates (for 2.0) #1497

Merged
merged 6 commits into from
Oct 25, 2021
Merged

Selinux updates (for 2.0) #1497

merged 6 commits into from
Oct 25, 2021

Conversation

treydock
Copy link
Contributor

This is same as #1496 but for 2.0 release

Docs:

Added booleans

  • ondemand_use_kubernetes
  • ondemand_use_ssh

Deprecated booleans:

  • ondemand_use_shell_app

@treydock treydock mentioned this pull request Oct 23, 2021
Merged
johrstrom
johrstrom approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the mainline PR. If we're OK to use admin_home_t then I'm OK too.

@treydock
Copy link
Contributor Author

I think only way to not use admin_home_t is deploy policy to change context of /root/.kube but I fear what unintended consequences that would have so I think way things are is safest and least likely to break people's systems.

@johrstrom johrstrom merged commit 40f65f8 into release_2.0 Oct 25, 2021
@johrstrom johrstrom deleted the selinux-updates-2.0 branch October 25, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johrstrom johrstrom johrstrom approved these changes

Assignees
No one assigned
Labels
needs doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@treydock @johrstrom