Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a smart attribute for automatically loading modules #1930

Merged
merged 7 commits into from Apr 7, 2022

Conversation

johrstrom
Copy link
Contributor

@johrstrom johrstrom commented Mar 29, 2022

Fixes #1923

┆Issue is synchronized with this Asana task by Unito

@johrstrom johrstrom marked this pull request as ready for review April 4, 2022 20:44
Copy link
Contributor

@gbyrket gbyrket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jeff. When adding the form field "auto_modules_app_jupyter" to the form, the form field does show up. What I am not understanding is that I thought this would be a drop-down to auto-load available modules for the given app. What am I missing?

@johrstrom
Copy link
Contributor Author

set OOD_MODULE_FILE_DIR i think to /etc/reporting/lmod to read the modules.

@treydock
Copy link
Contributor

treydock commented Apr 6, 2022

If that path is at OSC, it should be /users/reporting/lmod

@gbyrket
Copy link
Contributor

gbyrket commented Apr 6, 2022

@johrstrom

Should the available modules show up as a drop-down in that form field? I've set OOD_MODULE_FILE_DIR="/users/reporting/lmod" in dashboard/.env.local, restarted my pun and the field is showing as a input box. In ondemand, i'm on branch "auto-modules"

What am i missing?

@johrstrom
Copy link
Contributor Author

Can you share your form.yml?

Here's a simple one I've been testing with.

---
cluster:
  - "pitzer"
  - "owens"

form:
  - auto_modules_matlab
  - auto_modules_app_jupyter

Copy link
Contributor

@gbyrket gbyrket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality is confirmed.

Copy link
Contributor

@gbyrket gbyrket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and functions properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support auto populating modules in batch connect forms
5 participants