Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor id method with partials #3148

Merged
merged 3 commits into from
Oct 31, 2023
Merged

refactor id method with partials #3148

merged 3 commits into from
Oct 31, 2023

Conversation

akuppa9
Copy link
Contributor

@akuppa9 akuppa9 commented Oct 30, 2023

No description provided.

@johrstrom
Copy link
Contributor

You're commit isn't quite right. I'll get with you on slack to fix it.

image

Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@johrstrom johrstrom merged commit ed3512e into master Oct 31, 2023
23 checks passed
@johrstrom johrstrom deleted the refactor-id-partial branch October 31, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants