Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add close buttons to this modal #3328

Merged
merged 1 commit into from
Feb 2, 2024
Merged

add close buttons to this modal #3328

merged 1 commit into from
Feb 2, 2024

Conversation

johrstrom
Copy link
Contributor

add close buttons to this modal because there were none before.

This also changes h5 tags to just divs for accessibility.

Copy link
Contributor

@Oglopf Oglopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@johrstrom johrstrom merged commit 795a90b into master Feb 2, 2024
20 checks passed
@johrstrom johrstrom deleted the add-close-buttons branch February 2, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants