Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error at /apps/show/:name?path=x #3335

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

matt257
Copy link
Contributor

@matt257 matt257 commented Feb 5, 2024

The route

app GET /apps/show/:name(/:type(/:owner))(.:format) apps#show {:type=>"sys"}

with a 'path' URL parameter causes an application error.

#<NoMethodError: undefined method `uri' for #<AppsController:0x0000000001f5e0>
Did you mean?  URI>
...

Example using 'myjobs':

https://ondemand-test.osc.edu/pun/sys/dashboard/apps/show/myjobs
redirects to
https://ondemand-test.osc.edu/pun/sys/myjobs without issues.

https://ondemand-test.osc.edu/pun/sys/dashboard/apps/show/myjobs?path=x
causes the above error.

I verified after the change dashboard/apps/show/myjobs?path=x redirects to /myjobs/x and displays the below instead of an error.

The page you were looking for doesn't exist.
You may have mistyped the address or the page may have moved.

If you are the application owner check the logs for more information.

Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johrstrom johrstrom merged commit c8f2e70 into master Feb 5, 2024
20 checks passed
@johrstrom johrstrom deleted the controller-review branch February 5, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants