pm respond to README #3678
Merged
pm respond to README #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Jul 17, 2024
johrstrom
reviewed
Jul 17, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I'm still looking at this a bit to see if we need all this complexity. It could be the case that we do, but it seems to me that it should be easier. |
johrstrom
reviewed
Jul 22, 2024
johrstrom
reviewed
Jul 22, 2024
|
🤦♂️ looks like we have a conflict you need to resolve. |
johrstrom
reviewed
Jul 25, 2024
Comment on lines
11
to
14
| return sanitize(markdown_html) | ||
| elsif File.extname(readme_location) == '.txt' | ||
| # simple_format sanitizes its output | ||
| return simple_format(file_content) |
There was a problem hiding this comment.
I wasn't going to mention this, but now that I see there's a conflict to resolve I may as well.
You don't need the return statements here. I use solargraph with vscode to see stuff like this. It would tell you you don't need them here. It's really helpful for small idioms like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on #3377
Will render the README.md or README.txt in a project root to the projects#show page.