-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pm respond to README #3678
pm respond to README #3678
Conversation
I'm still looking at this a bit to see if we need all this complexity. It could be the case that we do, but it seems to me that it should be easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🤦♂️ looks like we have a conflict you need to resolve. |
return sanitize(markdown_html) | ||
elsif File.extname(readme_location) == '.txt' | ||
# simple_format sanitizes its output | ||
return simple_format(file_content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't going to mention this, but now that I see there's a conflict to resolve I may as well.
You don't need the return
statements here. I use solargraph
with vscode to see stuff like this. It would tell you you don't need them here. It's really helpful for small idioms like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Work on #3377
Will render the README.md or README.txt in a project root to the projects#show page.