Files: update dependencies using resolutions #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use resolutions for minimist, node-uuid, and tar-stream to enforce later versions than older ones that are dependended on by cloud commander dependencies
johrstrom
approved these changes
Sep 3, 2020
|
The others were confirmed to work. The only questionable one is tar-stream, but our Files app does not make use of it. It was for the original cloud commander server route to tar up a directory and stream that to the user, but we provide our own using zip instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use resolutions for minimist, node-uuid, and tar-stream to enforce later versions than older ones that are dependended on by cloud commander dependencies.
This is pulling back into production changes we made to 1.6 and 1.7 to address some dependencies with security issues.