Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.0 issues with Kubernetes #758

Closed
treydock opened this issue Jun 3, 2022 · 1 comment · Fixed by #759
Closed

Ruby 3.0 issues with Kubernetes #758

treydock opened this issue Jun 3, 2022 · 1 comment · Fixed by #759

Comments

@treydock
Copy link
Contributor

treydock commented Jun 3, 2022

Got this on OSC dev instance trying to submit Kubernetes job:

#<ArgumentError: wrong number of arguments (given 1, expected 0)>

/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/ood_core-0.19.0/lib/ood_core/job/adapters/kubernetes/k8s_job_info.rb:5:in `initialize'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/ood_core-0.19.0/lib/ood_core/job/adapters/kubernetes/helper.rb:34:in `new'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/ood_core-0.19.0/lib/ood_core/job/adapters/kubernetes/helper.rb:34:in `info_from_json'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/ood_core-0.19.0/lib/ood_core/job/adapters/kubernetes/batch.rb:101:in `info'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/ood_core-0.19.0/lib/ood_core/job/adapters/kubernetes.rb:148:in `info'
/var/www/ood/apps/sys/dashboard/app/models/batch_connect/session.rb:366:in `update_info'
/var/www/ood/apps/sys/dashboard/app/models/batch_connect/session.rb:357:in `info'
/var/www/ood/apps/sys/dashboard/app/models/batch_connect/session.rb:351:in `status'
/var/www/ood/apps/sys/dashboard/app/models/batch_connect/session.rb:424:in `completed?'
/var/www/ood/apps/sys/dashboard/app/models/batch_connect/session.rb:129:in `block in all'
/var/www/ood/apps/sys/dashboard/app/models/batch_connect/session.rb:128:in `map'
/var/www/ood/apps/sys/dashboard/app/models/batch_connect/session.rb:128:in `all'
/var/www/ood/apps/sys/dashboard/app/controllers/batch_connect/sessions_controller.rb:7:in `index'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/abstract_controller/base.rb:228:in `process_action'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_controller/metal/rendering.rb:30:in `process_action'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/abstract_controller/callbacks.rb:42:in `block in process_action'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/activesupport-6.1.5.1/lib/active_support/callbacks.rb:106:in `run_callbacks'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/abstract_controller/callbacks.rb:41:in `process_action'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_controller/metal/rescue.rb:22:in `process_action'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_controller/metal/instrumentation.rb:34:in `block in process_action'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/activesupport-6.1.5.1/lib/active_support/notifications.rb:203:in `block in instrument'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/activesupport-6.1.5.1/lib/active_support/notifications/instrumenter.rb:24:in `instrument'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/activesupport-6.1.5.1/lib/active_support/notifications.rb:203:in `instrument'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_controller/metal/instrumentation.rb:33:in `process_action'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_controller/metal/params_wrapper.rb:249:in `process_action'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/abstract_controller/base.rb:165:in `process'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionview-6.1.5.1/lib/action_view/rendering.rb:39:in `process'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_controller/metal.rb:190:in `dispatch'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_controller/metal.rb:254:in `dispatch'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/routing/route_set.rb:50:in `dispatch'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/routing/route_set.rb:33:in `serve'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/journey/router.rb:50:in `block in serve'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/journey/router.rb:32:in `each'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/journey/router.rb:32:in `serve'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/routing/route_set.rb:842:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/rack-2.2.3.1/lib/rack/tempfile_reaper.rb:15:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/rack-2.2.3.1/lib/rack/etag.rb:27:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/rack-2.2.3.1/lib/rack/conditional_get.rb:27:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/rack-2.2.3.1/lib/rack/head.rb:12:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/http/permissions_policy.rb:22:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/http/content_security_policy.rb:19:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/rack-2.2.3.1/lib/rack/session/abstract/id.rb:266:in `context'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/rack-2.2.3.1/lib/rack/session/abstract/id.rb:260:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/middleware/cookies.rb:689:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/middleware/callbacks.rb:27:in `block in call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/activesupport-6.1.5.1/lib/active_support/callbacks.rb:98:in `run_callbacks'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/middleware/callbacks.rb:26:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/middleware/actionable_exceptions.rb:18:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/middleware/debug_exceptions.rb:29:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/lograge-0.12.0/lib/lograge/rails_ext/rack/logger.rb:18:in `call_app'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/railties-6.1.5.1/lib/rails/rack/logger.rb:26:in `block in call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/activesupport-6.1.5.1/lib/active_support/tagged_logging.rb:99:in `block in tagged'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/activesupport-6.1.5.1/lib/active_support/tagged_logging.rb:37:in `tagged'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/activesupport-6.1.5.1/lib/active_support/tagged_logging.rb:99:in `tagged'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/railties-6.1.5.1/lib/rails/rack/logger.rb:26:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/middleware/remote_ip.rb:81:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/request_store-1.5.1/lib/request_store/middleware.rb:19:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/middleware/request_id.rb:26:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/rack-2.2.3.1/lib/rack/method_override.rb:24:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/rack-2.2.3.1/lib/rack/runtime.rb:22:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/activesupport-6.1.5.1/lib/active_support/cache/strategy/local_cache_middleware.rb:29:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/middleware/executor.rb:14:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/rack-2.2.3.1/lib/rack/sendfile.rb:110:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/actionpack-6.1.5.1/lib/action_dispatch/middleware/host_authorization.rb:142:in `call'
/opt/ood/ondemand/root/usr/share/gems/3.0/ondemand/2.1.20220603/gems/railties-6.1.5.1/lib/rails/engine.rb:539:in `call'
/opt/rh/ondemand/root/usr/share/ruby/vendor_ruby/phusion_passenger/rack/thread_handler_extension.rb:107:in `process_request'
/opt/rh/ondemand/root/usr/share/ruby/vendor_ruby/phusion_passenger/request_handler/thread_handler.rb:149:in `accept_and_process_next_request'
/opt/rh/ondemand/root/usr/share/ruby/vendor_ruby/phusion_passenger/request_handler/thread_handler.rb:110:in `main_loop'
/opt/rh/ondemand/root/usr/share/ruby/vendor_ruby/phusion_passenger/request_handler.rb:419:in `block (3 levels) in start_threads'
/opt/rh/ondemand/root/usr/share/ruby/vendor_ruby/phusion_passenger/utils.rb:113:in `block in create_thread_and_abort_on_exception'

┆Issue is synchronized with this Asana task by Unito

@treydock
Copy link
Contributor Author

treydock commented Jun 3, 2022

Actually there are a lot of Ruby 3.0 issues with ood_core. I am working to fix them up as very similar changes to what we did in main ondemand repo.

treydock added a commit that referenced this issue Jun 3, 2022
@treydock treydock mentioned this issue Jun 3, 2022
treydock added a commit that referenced this issue Jun 3, 2022
* Support Ruby 3
Fixes #758 

* Bump to 0.19.1 and add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant