Make Linux Host adapter delete function more portable #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… under the name shim-init and not just sinit
johrstrom
reviewed
Oct 22, 2021
Comment on lines
75
to
+76
| # Find the Singularity sinit PID child of the pane process | ||
| pane_sinit_pid=$(pstree -p -l "$pane_pid" | grep -o 'sinit([[:digit:]]*' | grep -o '[[:digit:]]*') | ||
| pane_sinit_pid=$(pstree -p -l "$pane_pid" | egrep -o 'sinit[(][[:digit:]]*|shim-init[(][[:digit:]]*' | grep -o '[[:digit:]]*') |
There was a problem hiding this comment.
Seems like greping trough pstree output isn't super stable. Or at least, there has to be a better way. Not clear why we didn't use tmux to list and stop the sessions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making apps that run on an old Fedora 27 box, ran into an issue where the sinit process is actually named shim-init. This was failing the original grep in the kill function and apps could not be killed.
Switched the grep to an egrep, added the shim-init as an or option and used
[]to escape the ( as older egreps can have problems with the standard ( escape.Commit comment:
extended Linux Host adapter kill function grep to also find processes under the name shim-init and not just sinit