Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for nohttpd option before using it with vncserver #767

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

johrstrom
Copy link
Contributor

Fixes #737

@@ -86,8 +86,13 @@ def before_script
# Clean up any old VNC sessions that weren't cleaned before
#{vnc_clean}

#for turbovnc 3.0 compatability.
if timeout 2 vncserver --help 2>&1 | grep 'nohttpd' >/dev/null 2>&1; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure be nice if there was a way to get the version, but just looked and appears the module installed on OSC systems does not have any kind of version flag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol yea that's why I went for this version. Also may be compatible with tigervnc? I've seen folks have that installed instead and it cause issues.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We install tigervnc on bastion servers:

$ vncserver --help

usage: vncserver [:<number>] [-name <desktop-name>] [-depth <depth>]
                 [-geometry <width>x<height>]
                 [-pixelformat rgbNNN|bgrNNN]
                 [-fp <font-path>]
                 [-cc <visual>]
                 [-fg]
                 [-autokill]
                 [-noxstartup]
                 [-xstartup <file>]
                 [-fallbacktofreeport]
                 <Xvnc-options>...

       vncserver -kill <X-display>

       vncserver -list

Looks like your logic would work there too.

@johrstrom johrstrom marked this pull request as ready for review July 20, 2022 17:50
@johrstrom
Copy link
Contributor Author

I've got a ticket with Sci apps to get 3.0 on OSC systems. Would like to test this first, but I'd also like to get it into the next 2.0 release because it's a real pain point for folks.

@johrstrom
Copy link
Contributor Author

I was able to confirm this works with a module I built myself. The script_wrapper had set -x so here's the output of the 2 cases:

With 2.2.6

+ grep nohttpd
+ timeout 2 vncserver --help
+ HTTPD_OPT=-nohttpd
++ vncserver -log vnc.log -rfbauth vnc.passwd -nohttpd -noxstartup -geometry 1536x864
+ VNC_OUT='

with 3.0

+ vncserver -list
+ grep nohttpd
+ timeout 2 vncserver --help
++ vncserver -log vnc.log -rfbauth vnc.passwd -noxstartup -geometry 1536x864
+ VNC_OUT='

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TurboVNC 2.2.90 lacks the -nohttpd option
2 participants