-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for nohttpd option before using it with vncserver #767
Conversation
@@ -86,8 +86,13 @@ def before_script | |||
# Clean up any old VNC sessions that weren't cleaned before | |||
#{vnc_clean} | |||
|
|||
#for turbovnc 3.0 compatability. | |||
if timeout 2 vncserver --help 2>&1 | grep 'nohttpd' >/dev/null 2>&1; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure be nice if there was a way to get the version, but just looked and appears the module installed on OSC systems does not have any kind of version flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol yea that's why I went for this version. Also may be compatible with tigervnc
? I've seen folks have that installed instead and it cause issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We install tigervnc on bastion servers:
$ vncserver --help
usage: vncserver [:<number>] [-name <desktop-name>] [-depth <depth>]
[-geometry <width>x<height>]
[-pixelformat rgbNNN|bgrNNN]
[-fp <font-path>]
[-cc <visual>]
[-fg]
[-autokill]
[-noxstartup]
[-xstartup <file>]
[-fallbacktofreeport]
<Xvnc-options>...
vncserver -kill <X-display>
vncserver -list
Looks like your logic would work there too.
I've got a ticket with Sci apps to get 3.0 on OSC systems. Would like to test this first, but I'd also like to get it into the next 2.0 release because it's a real pain point for folks. |
I was able to confirm this works with a module I built myself. The script_wrapper had With 2.2.6
with 3.0
|
Fixes #737