Added Functionality to support Non-Standard SSH Port in the Adapters. #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Feb 16, 2023
lib/ood_core/job/adapters/helper.rb
Outdated
| @@ -26,7 +26,7 @@ def self.ssh_wrap(submit_host, cmd, cmd_args, strict_host_checking = true, env = | |||
| return cmd, cmd_args if submit_host.to_s.empty? | |||
|
|
|||
| check_host = strict_host_checking ? "yes" : "no" | |||
| args = ['-o', 'BatchMode=yes', '-o', 'UserKnownHostsFile=/dev/null', '-o', "StrictHostKeyChecking=#{check_host}", "#{submit_host}"] | |||
| args = ['-p', ENV["OOD_SSH_PORT"].nil? ? "22" : "#{ENV['OOD_SSH_PORT']}", '-o', 'BatchMode=yes', '-o', 'UserKnownHostsFile=/dev/null', '-o', "StrictHostKeyChecking=#{check_host}", "#{submit_host}"] | |||
There was a problem hiding this comment.
Can you put this logic in a helper function like this so other things can just refercen the fuction without the logic. (also be sure to cast to an integer)
def ssh_port
ENV["OOD_SSH_PORT"].nil? ? "22" : ENV['OOD_SSH_PORT'].to_i.to_s
endThere was a problem hiding this comment.
Can you put this logic in a helper function like this so other things can just refercen the fuction without the logic. (also be sure to cast to an integer)
def ssh_port ENV["OOD_SSH_PORT"].nil? ? "22" : ENV['OOD_SSH_PORT'].to_i.to_s end
The Helper is a good idea. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Functionality to support Non-Standard SSH Port in the Adapters.
The environment variable for ssh port is: ENV['OOD_SSH_PORT']
┆Issue is synchronized with this Asana task by Unito