find_port: avoid infinite loop #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If all ports in chosen port range were taken, `find_port` had the tendency to block. This fix updates the code to avoid this and instead attempt to find a port by looping over the port range for a fixed number of retries.
johrstrom
approved these changes
Jul 31, 2023
|
thanks for the quick merge! Working on a few more cleanups for issues we encountered under AzHOP. Just wanted to introduce myself to the dev team and familiarize myself with the workflow with this small PR :). |
|
Well hello there! PRs welcome - that's pretty much the policy. I'm working on a 3.0.2 patch release, so i'll try to get this in there. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all ports in chosen port range were taken,
find_porthad the tendency to block. This fix updates the code to avoid this and instead attempt to find a port by looping over the port range for a fixed number of retries.