Fixed boolean check for boolean parameter #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@treydock Is this the best way to submit changes/requests for the Puppet Module? CC: @johrstrom |
treydock
approved these changes
Apr 13, 2023
|
@abujeda You will need to rebase against master branch to resolve the tests not running. There were some changes recently to fix the testing and looks like your branch doesn't have them. |
abujeda
force-pushed
the
cluster_strict_host_checking_fix
branch
from
c75c695
to
a624953
Compare
abujeda
force-pushed
the
cluster_strict_host_checking_fix
branch
from
a624953
to
f0216c9
Compare
|
Thanks @treydock. Rebased completed. |
|
This is released as v3.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the check for
@job_strict_host_checkingin theopenondemand::clustertemplate. As it is a boolean and when set tofalse, the check fails and will not render the value.