Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed Nginx stage ondemand title default value #142

Merged
merged 3 commits into from Nov 27, 2023
Merged

Removed Nginx stage ondemand title default value #142

merged 3 commits into from Nov 27, 2023

Conversation

abujeda
Copy link
Contributor

@abujeda abujeda commented Nov 22, 2023

Removed Nginx stage ondemand title default value for 2 reasons.

  • This is not needed as the dashboard application already defaults to 'Open OnDemand'.
  • The dashboard title value cannot be overridden within user profiles as the ENV value is set and takes precedence.

@abujeda @treydock
Fixed nginx_stage_ondemand_title trailing space in template
e862f47 
Co-authored-by: treydock <treydock@gmail.com>
@treydock treydock added the bugfix Something isn't working label Nov 27, 2023
@treydock treydock merged commit 6e44eec into OSC:master Nov 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treydock treydock treydock left review comments

Assignees
No one assigned
Labels
bugfix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abujeda @treydock