Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELETED reactui-docs #69

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Conversation

mosespace
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # GH-54

Type of change

Please chose options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • pnpm:

Checklist:

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm run test to check if all tests are passing, and/or pnpm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.
  • I've included issue number in the "Closes #ISSUE-NUMBER" part of the "What are the relevant tickets?" section to link the issue.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

How should this be manually tested? Please include the steps to be done inorder to setup and test this PR.

Only the deleted should be verified

What are the relevant tickets? Closes

it closes issues #54

@netlify
Copy link

netlify bot commented Feb 25, 2023

Deploy Preview for delicate-stroopwafel-6af024 canceled.

Name Link
🔨 Latest commit a2fd416
🔍 Latest deploy log https://app.netlify.com/sites/delicate-stroopwafel-6af024/deploys/63f9eb5845a95b000758ba7b

@mosespace
Copy link
Member Author

@HassanBahati come review this

Copy link
Collaborator

@HassanBahati HassanBahati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me:clap: Thanks @mosespace

@HassanBahati HassanBahati merged commit e0815ff into OSCA-Kampala-Chapter:main Feb 25, 2023
@mosespace
Copy link
Member Author

@HassanBahati Thank you, looking forward to contributing more on the documentation and the good first issues!

@mosespace mosespace deleted the deleted branch February 25, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants