-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo controller code for pressure sensing #2
Comments
sorry about the close/reopen. I'm glad that it appears this repo is getting used again. |
I would like to help tidying up the code. As a first step all "versions of code floating around" could be listed commenting in this issue. Once we know which version is being used we can decide how to update/merge the code. |
The version which is HEAD of master branch here, is the version which has been reliably operating on my machine for a while now. Just as one data point. |
@dwiel Does your machine/code do pressure sensing to make sure all bricks have uniform pressure rather than uniform size? |
yep, I was the one to first design/implement that feature :) |
Oh sweet! :-) Do you know what version of the CEB press that is? I want to tag HEAD with ceb-press-7 or whatever. |
My CEB Press doesn't really have a version number that I am aware of. The steel is version 4, the controller is custom, but it was the controller version that James replicated at FeF for the presses used on the recent microhouse build. You know what version those were considered? |
That's great to know. We emailed James to ask if there's a version number On Thu, Oct 24, 2013 at 4:31 PM, Zach Dwiel notifications@github.comwrote:
|
sounds good |
I'd recommend to use as tag "v7.0" instead of something like "ceb-press-7"... |
If current master is the best-working version, then we just need to clean up/merge the folder |
I agree on v7.0. I think it makes sense to move stuff from |
There were some minor changes that were been made in the field at FeF during the microhouse build that I think could be merged back into master here, but should probably be re-factored into .h constants first, rather than replacing one constant with another. Will have to see @james' latest code to see what changes they had to make. I think it was mostly changes to constants, though I do remember a few additional code paths added to deal with the poor tolerances that their machines were constructed under. |
I like v7.0. We should delete the old code. That's what revision control is for! :-) Do one of you want to take ownership of this ticket? |
i vote for saving old code. put it up in the attic.
|
maybe we can tag where we are now, and then 'get rid of' old stuff. The whole point of using something like github is that nothing is every actually lost. I agree with @dbenamy |
Exactly. The old code is always accessible in history, very easily if we On Thu, Oct 24, 2013 at 9:10 PM, Zach Dwiel notifications@github.comwrote:
|
sweet! im a github noob. could we directly link to the github history on
|
OK. I just tagged v7.0 by creating a release: For reference, in the future even "noobs" 😄 can release the current master by going to that URL and clicking on "Draft new release". That will also create a git tag. The "release notes" will be whatever you put in the description of the release. That also gives us packages so the whole repo can be downloaded with a click. Does it look good to you? I will close this issue then. |
I like that you went ahead and did this :-) Based on what I've been able to find out, the current brick press is likely some combination of v2, v3, and v4 so it's sort of a mess. Do you feel like adding a note to the ceb press section on the wiki saying that that tag is in use on various real world brick presses? @dorkmo, you can see the history by clicking the "commits" button (it goes to https://github.com/OSE/ceb-controller/commits/master). From there you can view the code as it existed at any revision. It's not a bad idea to add some info on how to use git and github to the wiki, or maybe even better, to link to an existing one. I'd suggest putting it in a generic place rather than in one specific machine, since it'll be used for many of them. |
@tobami I'm updating the ceb press wiki pages based on some new info I got so I'll add references to the right github releases. |
@dbenamy yeah, I thought that if you don't like something I did, I can still easily fix the commit/tag 😄 |
What pages did you update so far? Should I still add a note as you suggest? In any case we could add a link to the wiki in the readme. |
I overhauled the whole CEB Press area on the wiki. If you go to I also updated the link to the code on That's everything I saw that needed updating. If you know of anything I On Sat, Oct 26, 2013 at 1:02 PM, Miquel Torres notifications@github.comwrote:
|
Oh, the project has a website link in place (top of On Sat, Oct 26, 2013 at 1:02 PM, Miquel Torres notifications@github.comwrote:
|
It turns out that old link was to a domain that went away. I updated the link to point to the wiki. |
OK, I updated the github project description. Everthing looks good now. |
sorry for resurrecting this thread, but it appears that the wrong set of I've gotten emails from multiple people asking how get their machine code zach On Sun, Oct 27, 2013 at 4:03 PM, Miquel Torres notifications@github.comwrote:
|
I agree that the github code should ideally reflect the current version Andrew Grahamhttp://www.vimeo.com/houdinifx/showreel On Sun, Apr 27, 2014 at 9:28 AM, Zach Dwiel notifications@github.comwrote:
|
ok cool. I've replied to an old thread that was the discussion around the On Sun, Apr 27, 2014 at 10:31 AM, queglay notifications@github.com wrote:
|
I have a copy of the code OSE is using on the wiki. We are still using it -James
|
ok cool, thanks James. It sounds like the code in this repo is the wrong On Sun, Apr 27, 2014 at 10:35 AM, queglay notifications@github.com wrote:
|
Yeah, you should totally put whatever's actually in use into master. We should also recreate the v3 and/or v4 releases as needed if it's not too much work: https://github.com/OSE/ceb-controller/releases. If it is too complicated, let's at least delete the wrong release(s). |
I've at least now got master on the right version. On Sun, Apr 27, 2014 at 3:17 PM, Daniel Benamy notifications@github.comwrote:
|
Nice! Is there any reason to build a custom board for this rather than using an arduino? |
At one point OSE (and I) wanted a custom board so that it could be made http://upverter.com/zdwiel/2d958299ddd5a35c/CEB-Press-Controller-Board-Schematic/ This schematic doesn't require any custom boards. James, do you know if zach On Sun, Apr 27, 2014 at 3:21 PM, Daniel Benamy notifications@github.comwrote:
|
Here's what I have for the build: You can also see more info here: I would really suggest using much higher grade buttons and toggles. The On Sun, Apr 27, 2014 at 2:28 PM, Zach Dwiel zdwiel@gmail.com wrote:
|
Nice, thanks On Sun, Apr 27, 2014 at 5:31 PM, James Slade jameswslade@gmail.com wrote:
|
@dwiel I wasn't on that email thread you replied to. Mind adding me? @queglay If master is right now, we should delete any copies of the code in the wiki and point everything at github so everyone's on the same page. That sound ok with you? I'm guessing the release tags are wrong which is going to confuse people trying to build this. In fact, I'm not even sure the concept of which machine is what version are clear :-) I think I better just delete the tags and releases and we'll try to get it right for the future. I emailed James when I was trying to straighten out the various versions on the wiki, but he didn't have a chance to reply. It's a shame because the mess on the wiki means far fewer people can benefit from all this awesome work. If it'd help, I'd be willing to hop on a quick phone call with anyone who can fill in some gaps in my knowledge, learn what's what, and then update the wiki a bit. |
The code that is used in the most recent set of CEB Presses @ FeF use zach On Sun, Apr 27, 2014 at 8:42 PM, Daniel Benamy notifications@github.comwrote:
|
Are we all in agreement that the latest code and starting point is the code MJ On Sun, Apr 27, 2014 at 9:35 AM, James Slade jameswslade@gmail.com wrote:
Get Involved: Would you spare me 5 minutes, print out this Marcin Jakubowski, Executive Director |
James got his code from me, and the code that I gave him is what is now On Wed, May 7, 2014 at 5:51 PM, queglay notifications@github.com wrote:
|
Agreed from my understanding
|
http://opensourceecology.org/wiki/File:CEB_code.rar That's the version I was using with minor tweaks specific to each machine.
|
I changed everything on the wiki that used to point to http://opensourceecology.org/wiki/File:CEB_code.rar, to instead point to the github repo. I also added a giant warning to that file page to come here instead :-) Hopefully this'll prevent future confusion with what version is the latest and where people should work. If anyone who wants to work on this isn't comfortable with git and github, I'd be happy to help you/them get up and running. |
Pressure sensing code is on the latest ceb press on factor e farm but we're not sure if it's been uploaded to git and there may be multiple versions of code floating around.
Figure out what code's in use now, by investigating on the ose wiki and asking the relevant people. Then update what's in github.
The text was updated successfully, but these errors were encountered: