SMHE-2011 Save firmware file to file system #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d digest Signed-off-by: Harry Middelburg <harry.middelburg@alliander.com>
Signed-off-by: Harry Middelburg <harry.middelburg@alliander.com>
…ering specific). Add optional hash and hash_type Signed-off-by: Harry Middelburg <harry.middelburg@alliander.com>
Signed-off-by: Harry Middelburg <harry.middelburg@alliander.com>
Signed-off-by: Harry Middelburg <harry.middelburg@alliander.com>
…rvice Signed-off-by: Harry Middelburg <harry.middelburg@alliander.com>
…P/open-smart-grid-platform into feature/SMHE-2011_firmware-s3-bucket
Signed-off-by: Harry Middelburg <harry.middelburg@alliander.com>
Signed-off-by: Harry Middelburg <harry.middelburg@alliander.com>
…P/open-smart-grid-platform into feature/SMHE-2011_firmware-s3-bucket
Signed-off-by: Jaco Boon <jaco.boon@gmail.com.com>
Signed-off-by: Harry Middelburg <harry.middelburg@alliander.com>
….com/OSGP/open-smart-grid-platform into feature/SMHE-2011_firmware-s3-bucket
…P/open-smart-grid-platform into feature/SMHE-2011_firmware-s3-bucket
Signed-off-by: Harry Middelburg <harry.middelburg@alliander.com>
Signed-off-by: Jaco Boon <jaco.boon@gmail.com>
…P/open-smart-grid-platform into feature/SMHE-2011_firmware-s3-bucket
Signed-off-by: Jaco Boon <jaco.boon@gmail.com>
Signed-off-by: Harry Middelburg <harry.middelburg@alliander.com>
…gConfig Signed-off-by: Harry Middelburg <harry.middelburg@alliander.com>
stefanermens
requested changes
May 28, 2024
...ing/src/test/resources/features/osgp-adapter-ws-smartmetering/configuration/Firmware.feature
Outdated
Show resolved
Hide resolved
...rg/opensmartgridplatform/adapter/ws/core/application/services/FirmwareManagementService.java
Outdated
Show resolved
Hide resolved
...rg/opensmartgridplatform/adapter/ws/core/application/services/FirmwareManagementService.java
Outdated
Show resolved
Hide resolved
...idplatform/cucumber/platform/common/glue/steps/ws/core/firmwaremanagement/FirmwareSteps.java
Outdated
Show resolved
Hide resolved
...esources/features/common/osgp-adapter-ws-core/FirmwareManagement/AddOrChangeFirmware.feature
Outdated
Show resolved
Hide resolved
...esources/features/common/osgp-adapter-ws-core/FirmwareManagement/AddOrChangeFirmware.feature
Outdated
Show resolved
Hide resolved
...rg/opensmartgridplatform/adapter/ws/core/application/services/FirmwareManagementService.java
Outdated
Show resolved
Hide resolved
...ensmartgridplatform/adapter/ws/core/application/services/FirmwareFileStorageServiceTest.java
Show resolved
Hide resolved
...pensmartgridplatform/adapter/ws/core/application/services/FirmwareManagementServiceTest.java
Outdated
Show resolved
Hide resolved
...m/core/infra/jms/protocol/inbound/messageprocessors/GetFirmwareFileMessageProcessorTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Harry Middelburg <harry.middelburg@alliander.com>
|
stefanermens
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we removed the request back from dlms adapter to core in case a firmware file is not yet in the dlms adapter's cache repository when needed.
The firmware file content is no longer stored in the core database but stored by the core module on a configured file system. This file system is also reachable for the dlms adapter.
Firmware file is still read once and stored in the cache repository.
ImageIdentifier is removed from the core database since this was a smartmetering specific solution which is no longer needed now the ImageIdentifier is stored on a file system in the same way as the firmware file.
A hash is stored in the core database to check the content of the firmware file stored in the file system. For this content check hash and hashtype are added to the firmware file properties in the firmware requests.