Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviewed mapbender QuickStart #520

Merged
merged 3 commits into from
Jan 25, 2020
Merged

Reviewed mapbender QuickStart #520

merged 3 commits into from
Jan 25, 2020

Conversation

flicstar
Copy link
Collaborator

@flicstar flicstar commented Nov 4, 2019 •
edited
Loading

Reviewed as part of the QuickStart project during Google Season of Docs. The aim is consistency across all OSGeoLive QuickStarts.
@astroidex Please accept suggestions you agree with. See the template for reference: https://trac.osgeo.org/osgeolive/wiki/How%20to%20document%20the%20quickstart%20file

@flicstar
Copy link
Collaborator Author

flicstar commented Nov 4, 2019 •
edited
Loading

This document contains lots of really useful information. However, is too long to be a digestible Quickstart. It might overwhelm the reader.
My suggestions are mostly about removing content. It is valuable but would be better if it were moved elsewhere.
I suggest removing all the content about users, groups and roles. Perhaps instead you could hyperlink off to it?
The document is structured well and only requires minor changes.

@kalxas kalxas requested a review from astroidex November 5, 2019 13:01
@flicstar flicstar changed the title Reviewed by @flicstar for Google Season of Docs 2019 Reviewed mapbender QuickStart Nov 17, 2019
astroidex
astroidex reviewed Nov 27, 2019
View reviewed changes
Copy link
Member

@astroidex astroidex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @flicstar for your suggestions. All are fine. It was really to long. If we refer to the https://doc.mapbender.org/en/quickstart.html it is fine like that

doc/quickstart/mapbender_quickstart.rst Outdated Show resolved Hide resolved
doc/quickstart/mapbender_quickstart.rst Show resolved Hide resolved
@astroidex
Copy link
Member

Looks very good. Ready to be merged.

@camerons
Copy link
Contributor

Merged based on review from @astroidex

@camerons camerons merged commit d1ac32f into OSGeo:master Jan 25, 2020
@flicstar flicstar deleted the mapbender branch January 25, 2020 21:37
@cvvergara cvvergara added this to the Release 14.0.0 milestone Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astroidex astroidex astroidex left review comments

Assignees
No one assigned
Labels
enhancement GSoD
Projects
None yet
Milestone
Release 14.0.0
4 participants
@flicstar @astroidex @camerons @cvvergara