Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actinia quickstart update: new ace parser #702

Merged
merged 6 commits into from
Apr 14, 2021
Merged

actinia quickstart update: new ace parser #702

merged 6 commits into from
Apr 14, 2021

Conversation

neteler
Copy link
Member

@neteler neteler commented Mar 18, 2021 •
edited
Loading

After recent (unavoidable) update of the ace parser, i.e. turning it into a true GRASS GIS addon, most flags and parameters have changed accordingly. This PR updates the quickstart.

This PR affects the translations, and hence might be postponed to > v14.0.

@neteler
actinia quickstart update: new ace parser
1214a34 
After recent update of the `ace` parser, i.e. becoming a true GRASS GIS addon, most flags and parameters have to be updated accordingly. This PR updates the quickstart.
@neteler neteler added this to the Release 14.0.0 milestone Mar 18, 2021
@neteler neteler requested a review from kalxas March 18, 2021 21:58
@neteler neteler self-assigned this Mar 18, 2021
@neteler
Copy link
Member Author

neteler commented Mar 22, 2021

Sorry to bother but how to get this (partially) merged?
The old quickstart is no longer valid... would be a pity to ship v14 with a broken quickstart.

@kalxas
Copy link
Member

kalxas commented Mar 26, 2021

I have assigned to the docs team for review

@kalxas
Copy link
Member

kalxas commented Mar 31, 2021

@cvvergara @Bakaniko @astroidex any thoughts about this?
Would it be ok just to fix the code to avoid translation changes?

@neteler
Copy link
Member Author

neteler commented Apr 2, 2021

(I am also willing to take care of the German and Italian translations)

neteler added a commit to neteler/OSGeoLive-doc that referenced this pull request Apr 3, 2021
@neteler
actinia quickstart update: new ace parser (reduced)
85e2e0c 
Reduced version of OSGeo#702

After recent (unavoidable) update of the `ace` parser, i.e. turning it into a true GRASS GIS addon, most flags and parameters have changed accordingly. This PR updates the quickstart but limits it to the code sections except for one character which I will change in all translations.
@neteler neteler mentioned this pull request Apr 3, 2021
Merged
@neteler
Copy link
Member Author

neteler commented Apr 3, 2021

Would it be ok just to fix the code to avoid translation changes?

Done in PR #707. This PR has been updated and the description above as well.

@neteler neteler removed this from the Release 14.0.0 milestone Apr 3, 2021
@cvvergara
Copy link
Contributor

Sorry, missed the ping,
I see that documentation has changed on the frozen period, so for me its ok to make more changes.
But translations will be froze. aka Will not upload to transifex, and translated strings because of a change will be lost.

@cvvergara cvvergara merged commit 1df8ffa into OSGeo:master Apr 14, 2021
@cvvergara
Copy link
Contributor

@neteler Thanks for the PR

@neteler neteler deleted the actinia_updated_ace_parser branch April 14, 2021 07:27
@cvvergara cvvergara added this to the Release 14.0.0 milestone May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvvergara cvvergara cvvergara approved these changes

@kalxas kalxas Awaiting requested review from kalxas

@astroidex astroidex Awaiting requested review from astroidex

@Bakaniko Bakaniko Awaiting requested review from Bakaniko

Assignees

@neteler neteler

Labels
None yet
Projects
None yet
Milestone
Release 14.0.0
3 participants
@neteler @kalxas @cvvergara