Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETF quickstart documentation #748

Merged
merged 11 commits into from Jul 13, 2022
Merged

ETF quickstart documentation #748

merged 11 commits into from Jul 13, 2022

Conversation

jenriquesoriano
Copy link
Contributor

ETF quickstart documentation for OSGeoLive 15

astroidex
astroidex requested changes Jun 28, 2022
View reviewed changes
Copy link
Member

@astroidex astroidex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some comments in the quickstart. Are you working on the overview too?

doc/quickstart/ETF_quickstart.rst Outdated Show resolved Hide resolved
doc/quickstart/ETF_quickstart.rst Outdated Show resolved Hide resolved
doc/quickstart/ETF_quickstart.rst Outdated Show resolved Hide resolved
doc/quickstart/ETF_quickstart.rst Outdated Show resolved Hide resolved
doc/quickstart/ETF_quickstart.rst Outdated Show resolved Hide resolved
doc/quickstart/ETF_quickstart.rst Outdated Show resolved Hide resolved
doc/quickstart/ETF_quickstart.rst Outdated Show resolved Hide resolved
doc/quickstart/ETF_quickstart.rst Outdated Show resolved Hide resolved
doc/quickstart/ETF_quickstart.rst Outdated Show resolved Hide resolved
doc/quickstart/ETF_quickstart.rst Show resolved Hide resolved
jenriquesoriano and others added 7 commits June 29, 2022 09:12
@jenriquesoriano
Update ETF_quickstart.rst
84ead93 
Application typo corrected
@MarcoMinghini
Update ETF_quickstart.rst
4bfbb88 
Fix typos and improve the text. Still to be added:

* links to sample resources that OSGeoLive users can test in the ETF
* links to the full user documentation so that OSGeoLive users can know more
@MarcoMinghini
Update ETF_quickstart.rst
c1d1dea 
Fix typo
@MarcoMinghini
Update ETF_quickstart.rst
0ae7e2f 
Fix typo
@jenriquesoriano
Update ETF_quickstart.rst
070d77d 
different views
@jenriquesoriano
Update ETF_quickstart.rst
ec8fd3d 
typos and rephrases
same length for the ======
Resources and Whats next added
@jenriquesoriano
Update ETF_quickstart.rst
3c2e611 
Authors updated
@jenriquesoriano
Copy link
Contributor Author

Dear @astroidex , thanks a lot for your revision.
We have addressed all your comments, also adding some additional input.
We think it is ready for your revision.
Please let us know if further input is needed.

PS: we are incorporating the overview in a separate PR.

@cvvergara
Copy link
Contributor

In order to process the documentation a line in this file is needed
https://github.com/etf-validator/OSGeoLive-doc/blob/etf-quickstart/projects_info.csv

@cvvergara cvvergara marked this pull request as draft July 5, 2022 19:21
@jenriquesoriano
Update projects_info.csv
3a994c1 
Included ETF line in projects_info.csv under "Browser Facin GIS->Others".
Please note it is under discussion the application for OSGeo Community project: https://lists.osgeo.org/pipermail/incubator/2022-July/004496.html

Thanks a lot!
@jenriquesoriano
Copy link
Contributor Author

Included ETF line in projects_info.csv under "Browser Facing GIS->Others".

@jenriquesoriano jenriquesoriano marked this pull request as ready for review July 5, 2022 22:33
@jenriquesoriano
Move ETF from Browser Facing GIS -> Web Services
4209588 
It fits better in Web Services, as it provides an API for validation and an interface (but just to consume validation services)
@cvvergara
Copy link
Contributor

@jenriquesoriano
I can see that you have also a branch for the overview
Can you add those changes to this branch.
So that everything gets processed.

Also some images are missing,
This would be the equivalent of the missing images:
https://github.com/OSGeo/OSGeoLive-doc/tree/master/doc/images/projects/pgrouting
The names of the images have to be:
logo_ETF.png
ETF_screenshot.png
There are scripts that reference those files to build, for example, the presentation

Thanks.

cvvergara
cvvergara requested changes Jul 9, 2022
View reviewed changes
doc/quickstart/ETF_quickstart.rst Show resolved Hide resolved
doc/quickstart/ETF_quickstart.rst Show resolved Hide resolved
@cvvergara
Copy link
Contributor

cvvergara commented Jul 9, 2022 •
edited

@jenriquesoriano
The overview is missing:

https://github.com/OSGeo/OSGeoLive-doc/runs/7266725376?check_suite_focus=true#step:6:20

@cvvergara cvvergara mentioned this pull request Jul 13, 2022
Merged
@cvvergara cvvergara merged commit f497be1 into OSGeo:master Jul 13, 2022
@cvvergara cvvergara added this to the Release 15.0.0 milestone Jul 13, 2022
@cvvergara
Copy link
Contributor

@jenriquesoriano
The quickstart and overview have been merged in #748 where all thechnical problems are solved.

For the moment, EMT is located on Spatial tools

Please double check the overview and the quickstart, and if needed, do a PR.

@jenriquesoriano
Copy link
Contributor Author

Dear @cvvergara ,

thanks a lot for merging and accepting the PR.
Indeed we are working to provide a better version of the overview, more aligned with the rest of the tools, but for us it is perfectly OK to create a new PR accordingly.
Thanks again for all your efforts.

Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvvergara cvvergara cvvergara requested changes

@astroidex astroidex Awaiting requested review from astroidex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 15.0.0
5 participants
@jenriquesoriano @cvvergara @astroidex @manuelaromero-guadaltel @MarcoMinghini