Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use isohybrid only in amd64 architecture (#1831) #147

Merged
merged 2 commits into from
Dec 23, 2016
Merged

Conversation

kalxas
Copy link
Member

@kalxas kalxas commented Dec 23, 2016

No description provided.

@kalxas kalxas self-assigned this Dec 23, 2016
@bencaradocdavies
Copy link
Contributor

bencaradocdavies commented Dec 23, 2016

@kalxas isohybrid will work on i386; this change removes both isohybrid and UEFI, when all that is needed is to remove UEFI.

sudo mkisofs -D -r -V "$IMAGE_NAME" -cache-inodes -J -l -quiet -b \
isolinux/isolinux.bin -c isolinux/boot.cat -no-emul-boot \
-boot-load-size 4 -boot-info-table -o ../"$ISO_NAME.iso" .
fi
Copy link
Contributor

@bencaradocdavies bencaradocdavies Dec 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can insert sudo isohybrid ../"$ISO_NAME.iso" at the end of the non-amd64 block to make the ISO a non-UEFI isohybrid (same as for amd64 but no -u flag). This should give you a working isohybrid i386 ISO without UEFI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, you are right, will fix

@bencaradocdavies
Copy link
Contributor

bencaradocdavies commented Dec 23, 2016

@kalxas that looks good to me.

For the record, there is such a thing as i386 UEFI, it is just that Ubuntu ISOs do not support UEFI on i386.

-eltorito-alt-boot -e boot/grub/efi.img -no-emul-boot \
-o ../"$ISO_NAME.iso" .
sudo isohybrid -u ../"$ISO_NAME.iso"
#isohybrid used only in 64bit architecture
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this comment should be "UEFI supported only in amd64 architecture".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will fix, thanks

@kalxas
Copy link
Member Author

kalxas commented Dec 23, 2016

I was able to build alpha1 for i386 using this PR

@kalxas kalxas merged commit c7aea43 into OSGeo:master Dec 23, 2016
@kalxas kalxas deleted the 1831 branch December 23, 2016 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants