-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use isohybrid only in amd64 architecture (#1831) #147
Conversation
@kalxas isohybrid will work on i386; this change removes both isohybrid and UEFI, when all that is needed is to remove UEFI. |
sudo mkisofs -D -r -V "$IMAGE_NAME" -cache-inodes -J -l -quiet -b \ | ||
isolinux/isolinux.bin -c isolinux/boot.cat -no-emul-boot \ | ||
-boot-load-size 4 -boot-info-table -o ../"$ISO_NAME.iso" . | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can insert sudo isohybrid ../"$ISO_NAME.iso"
at the end of the non-amd64 block to make the ISO a non-UEFI isohybrid (same as for amd64 but no -u
flag). This should give you a working isohybrid i386 ISO without UEFI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, you are right, will fix
@kalxas that looks good to me. For the record, there is such a thing as i386 UEFI, it is just that Ubuntu ISOs do not support UEFI on i386. |
-eltorito-alt-boot -e boot/grub/efi.img -no-emul-boot \ | ||
-o ../"$ISO_NAME.iso" . | ||
sudo isohybrid -u ../"$ISO_NAME.iso" | ||
#isohybrid used only in 64bit architecture |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this comment should be "UEFI supported only in amd64 architecture".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will fix, thanks
I was able to build alpha1 for i386 using this PR |
No description provided.