-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hungarian grids #68
base: master
Are you sure you want to change the base?
Conversation
7a78d29
to
0a46b04
Compare
@brncsk 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks globally good to me. Besides the version change in copyright_and_licenses.csv, could you also completely revert the changes in index.html and files.geojson that contain unwanted changes (in particular file timestamps updates) ? I'll update them locally once this PR is merged
@rouault Sure, will do – to clarify: that means I should completely revert both 0a46b04 and 79c1ef1 right? |
@rouault after a couple of emails w/ @zsiki, we've bumped into problems (whether semantic or technical is yet to be tackled) wrt between which EPSG entities one of our grid is supposed to work. I'm going to tag this PR as draft until we figure how to address these problems. I'll get back to this, but in the meantime, please do not merge. |
Dear @brncsk ! Any news about the status of the merge? It would be highly appreciated. :-) |
@vbnhu Nope, sorry. It's on our backlog but with a rather low priority. If anyone wants to pick this up and run with it: the main concern seems to be that (as per the convo w/ @zsiki) As per @rouault's comment[1] on this PR's predecessor (proj-datumgrid#97) this does not make sense from PROJ's point of view – thus unsupported. The trick is, though, that despite all this,
I admittedly lack the knowledge to reconcile @rouault's and @zsiki's thoughts on the topic, so I basically gave up. |
that doesn't make much sense to me. Why wouldn't it be a transformation between HD72 and ETRS89 ? As I noted in OSGeo/proj-datumgrid#97 (comment), the values given by the Helmert transformation EPSG:1449 and etrs2eov_notowgs.gsb were consistent |
@brncsk @zsiki Looking at that, I kind of understand the idea of a "transformation onto |
This is basically a revival of OSGeo/proj-datumgrid#97 (after having been in contact with @zsiki and obtaining his permission to do so).
Things that have changed:
at_bev
) that fetches and converts the files from the https://github.com/OSGeoLabBp/eov2etrs repository.Things yet to be addressed:
@rouault We'd kindly like to request a preliminary review from you on whether these additions are acceptable – and also if we need to do anything else to get this into
master
.