Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential addition of CalCOFI Line/Station coordinate system #135

Closed
proj4-bot opened this issue May 22, 2015 · 14 comments
Closed

Potential addition of CalCOFI Line/Station coordinate system #135

proj4-bot opened this issue May 22, 2015 · 14 comments

Comments

@proj4-bot
Copy link

Reported by edweber on 13 Jan 2012 18:58 UTC
I am writing to ask if you would consider adding a pseudo-projection to the Proj4 library -- the Line/Station coordinate system of the California Cooperative Oceanic Fisheries Investigations program. The California Cooperative Oceanic Fisheries Investigations program, known as CalCOFI, is a joint
research program between the U.S. NOAA, University of California Scripps Oceanographic Institute, and California Department of Fish and Game. It is unique in that it has been collecting oceanographic and fisheries data together for more than sixty years, long before any other marine program was doing ecosystem-type studies. The CalCOFI line/station coordinate system is now used by several other programs on the U.S. west coast and by the Mexican Investigaciones Mexicanas de la Corriente de California program offshore of Baja California.

The CalCOFI line/station system is not really a projection in the sense that it's used for navigation or anything, just to indicate sample locations. It's really just a Mercator transform that is rotated -30 degrees to orient with the coast, and then units are changed. There is a full description of the system in this article:
http://www.calcofi.org/publications/calcofireport/v20/Vol_20_Eber___Hewitt.pdf
(although it has a few typos).

The addition would admittedly benefit a relatively small number of users but it's also a small amount of code. It would be a big improvement for us here at the Southwest Center because we use Proj as part of the R package "rgdal"extensively. Being able to use line/station coordinates in the standard spatial classes and functions in R is really nice. We also use the pyproj Python module and a little bit of GRASS.

I coded this as "+proj=calcofi" using the proj-4.7.0 source code but, to be honest, I have just learned enough C to do the job. I confirmed that it converts from lat/long to line/station and back correctly and consistently. However, if you were to agree to add the conversion, I think I would need someone to take a quick look to be sure the code is ok and some instructions on how to formally test and include this. The code is in PJ_calcofi.c, and then I added the "projection" to pj_list.h line 19, ../src/Makefile.am line
33, ../src/Makefile.in lines 64, 267, and 438, and ../src/Makefile.vc line 18. Thank you for your time and consideration.

Best regards,
Ed

Edward D. Weber, Ph.D.

Research Fisheries Biologist

NOAA Southwest Fisheries Science Center

8604 La Jolla Shores Drive

La Jolla, CA 92037-1508, U.S.A.

(858) 546-5676

ed.weber@noaa.gov

Last Modified by warmerdam on 21 Feb 2012 05:28 UTC

Migrated-From: https://trac.osgeo.org/proj/ticket/135

@proj4-bot
Copy link
Author

Modified by warmerdam on 21 Feb 2012 05:28 UTC

@proj4-bot
Copy link
Author

Comment by warmerdam on 21 Feb 2012 05:38 UTC
I test built the code and had to make a slight change in trunk. However, I'd prefer to have some meaningful test points and docs suitable for the [wiki:FAQ] similar to what we have for HEALPIX in level of detail before I incorporate this in trunk.

I have attached the change as a patch against trunk.

@proj4-bot
Copy link
Author

Comment by warmerdam on 22 Feb 2012 17:01 UTC
Small change of plan, docs should be added under [wiki:ProjList]

@proj4-bot
Copy link
Author

Comment by edweber on 23 Feb 2012 05:48 UTC
I used the healpix web page as a template for the documentation page and assumed the file structure on the server would be similar. A figure is also attached which belongs in the 'proj=calcofi_files' directory. I haven't uploaded the other files for that directory:jsquery.js, proj_logo.png, search.js, trac_logo_mini.png, trac.css, trac.js, tracsectionedit.js, or wiki.css because they are exactly the same as those in the 'proj=healpix_files' directory.
A modified testvarious script with a few calcofi reference points is also attached.
Thank you again for your help with this,
Ed

@proj4-bot
Copy link
Author

Comment by warmerdam on 9 Jul 2013 03:42 UTC
Ed, I have added this projection in time for 4.9.0 (142dc13b (SVN rev2376)).

Note that the ProjList page is a wiki, so you can add your new page of docs yourself.

@proj4-bot
Copy link
Author

Attachment added by edweber on 13 Jan 2012 18:59 UTC
https://trac.osgeo.org/proj/attachment/ticket/135/PJ_calcofi.c

@proj4-bot
Copy link
Author

Attachment added by edweber on 13 Jan 2012 19:00 UTC
https://trac.osgeo.org/proj/attachment/ticket/135/pj_list.h

@proj4-bot
Copy link
Author

Attachment added by edweber on 13 Jan 2012 19:00 UTC
https://trac.osgeo.org/proj/attachment/ticket/135/Makefile.am

@proj4-bot
Copy link
Author

Attachment added by edweber on 13 Jan 2012 19:00 UTC
https://trac.osgeo.org/proj/attachment/ticket/135/Makefile.in

@proj4-bot
Copy link
Author

Attachment added by edweber on 13 Jan 2012 19:01 UTC
https://trac.osgeo.org/proj/attachment/ticket/135/makefile.vc

@proj4-bot
Copy link
Author

Attachment added by warmerdam on 21 Feb 2012 05:38 UTC
https://trac.osgeo.org/proj/attachment/ticket/135/calcofi.patch

@proj4-bot
Copy link
Author

Attachment added by edweber on 23 Feb 2012 05:28 UTC
https://trac.osgeo.org/proj/attachment/ticket/135/proj=calcofi.html

@proj4-bot
Copy link
Author

Attachment added by edweber on 23 Feb 2012 05:28 UTC
https://trac.osgeo.org/proj/attachment/ticket/135/calcofi.png

@proj4-bot
Copy link
Author

Attachment added by edweber on 23 Feb 2012 05:30 UTC
https://trac.osgeo.org/proj/attachment/ticket/135/testvarious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant