OGR_GRASS: fix regression after switch to GetGDALDriverManager #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilason
force-pushed
the
fix_ogr_grass_driver
branch
from
5a9a1de
to
b484c2a
Compare
OGR_GRASS driver was broken with 1f6a624 as it was not working as it was, by registering with GetGDALDriverManager. The unneeded OGRGRASSDriver class is removed and its use is replaced with GDALDriver. In related code 'bool', 'false' ,'true', 'nullptr' is used where appropriate.
nilason
force-pushed
the
fix_ogr_grass_driver
branch
from
b484c2a
to
317aefd
Compare
Merged
|
Lacking experience with GDAL code, I’d be grateful for review for this PR. Perhaps @rouault could jump in? |
Thanks Even! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OGR_GRASS driver was broken with 1f6a624 as it was not working as it was, by registering with GetGDALDriverManager.
The unneeded OGRGRASSDriver class is removed and its use is replaced with GDALDriver.
In related code 'bool', 'false' ,'true', 'nullptr' is used where appropriate.