-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] r.fuzzy.system: incorrect output #176
Comments
Rather than clicking to diagnose the bug, it can be seen via the CLI with
Note in the output that both have
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Name of the addon
r.fuzzy.system
Describe the bug
The output of
r.fuzzy.system
does not label the raster correctly. The output result is a DCELL raster with values defined by the defuzzification rules, AND labels for each value that provide the fuzzy set values prior to the defuzzification. Those labels are incorrect. The numerical values may also be incorrect, but I need to dig into this further before I can be certain.To Reproduce
Run a simple
r.fuzzy.system
and examine the outputs. Visually the output raster appears correct, but the labels assign the wrong fuzzy classes. I'm also concerned that the output is not just labeled incorrectly, but is also numerically incorrect.Example to be run in
nc_spm_08_grass7
Expected behavior
Correct labeling
Screenshots
Crisp result
![crisp](https://user-images.githubusercontent.com/145117/82606217-91508280-9b6b-11ea-8bb3-7dcd03c3e439.png)
Fuzzy result
![fuzzy](https://user-images.githubusercontent.com/145117/82605423-c4dedd00-9b6a-11ea-91ea-f6046aae5149.png)
But, clicking near a road shows this:
![click](https://user-images.githubusercontent.com/145117/82605514-e344d880-9b6a-11ea-84ec-899553c9c3f1.png)
Having both
near=1.0
andfar=1.0
is incorrect. That situation should never exist, becausenear = 1
output occurs whendist = near
, which is defined asdist < 1000
. From 1000 to 2000dist
is still near, but with membership < 1.0. Furthermore, output withfar = 1
occurs whendist = far
, which only occurs with full membeship (far = 1
) fordist > 2000
. The two do not overlap.Examining the
fuzzy_near
andfuzzy_far
maps made with the-m
option tor.fuzzy.system
verifies that the membership withfuzzy_far
is 0 if you click near a road.Finally, maximum fuzzy values are never equal to 1 (full membership) even when they should be - for example when
fuzzy_near = 1
andfuzzy_far = 0
, regardless of theimplication
,family
, ordefuz
options selected. From this I question the correctness of the numerical results, not just the label results.System description (please complete the following information):
Linux, GRASS GIS 7.8.2
The text was updated successfully, but these errors were encountered: